How to properly display jalali dates for Persian language

l3est · 2017-05-06 20:16:32 UTC

I’m a new rails/discourse developer. I’m wondering if someone could tell me about discourse structure.
I wanted to edit some view files so I edited discourse/app/views/[view-folder]/[*.html.erb] files and nothing changed, even static text like ‘test’ didn’t show up in website.
could you tell me which files can change things on website template?

pfaffman · 2017-05-05 13:19:03 UTC

Did you set up a development server? Also, if you are going to make changes and ever want to upgrade Discourse, you should develop plugins.

l3est · 2017-05-05 13:59:45 UTC

I have installed discourse on Ubuntu and docker.
I want to change template dates to jalali dates and I don’t know where to start.

l3est · 2017-05-05 18:48:39 UTC

I’m trying to make a plugin to convert gregorian dates to jalali date.
this is what I’ve done so far :
plugin.rb file :

# name: تاریخ شمسی
# about: تاریخ شمسی Discourse
# version: 1.0
# authors: l3est

# javascript
register_asset "javascripts/moment-jalaali.js", :server_side

this is moment-jalaali.js file :

and added translated date formats:
YYYY MM changes to jYYYY jMM

and there is assets\javascripts folder in plugin main folder, this is the plugin structure:
jalaali-date
plugin.rb
-assets
–javascripts
—moment-jalaali.js

pfaffman · 2017-05-05 23:24:35 UTC

Hey @erlend_sh. Is this the kind of translation that should be in core?

l3est · 2017-05-06 06:05:37 UTC

I think it should be for persian language files (client.fa_IR.yml and server.fa_IR.yml) . but no others.

Does anyone know how can I change formatter.js.es6 dates to jajali with plugin ?
the moment-jalali library works on chrome console when website loads.

tophee · 2017-05-06 11:33:57 UTC

In case you haven’t seen it yet, this might be useful:

l3est · 2017-05-06 19:15:47 UTC

thanks for the link. I’ve seen this before.
I know how to make plugins. I just don’t know where I can edit dates before it gets to user browser.

DeanMarkTaylor · 2017-05-06 19:29:22 UTC

You don’t…

I believe (hopefully someone will correct me if I’m wrong)…

…for the most part dates and times are stored in UTC/GMT server side and translated to the local user’s time zone in the browser (client side).

l3est · 2017-05-06 19:38:03 UTC

I think I’m not explaining well.

I’m looking for specific files that format dates before sending it to browser, so I’ll be able to add moment-jalali or other jalali date converters to it to get jalali date in browser.

l3est · 2017-05-06 19:59:39 UTC

I found this file:
discourse/app/assets/javascripts/discourse/lib/formatter.js.es6

this is the file that returns date to web browser. the question is how can I add the moment-jalali.js file to this? then everything will be ok.
client.fa_IR.yml file has ‘jYYYY jMM jD’ format instead of ‘YYYY MM D’ (for fa_IR language only)
here’s an example how moment-jalali works:
m.format('jYYYY/jM/jD [is] YYYY/M/D') // 1360/5/26 is 1981/8/17

DeanMarkTaylor · 2017-05-06 20:18:16 UTC

I haven’t done translations before, however - my understanding is that…

All translations are supplied via Discourse localization

This at some point then is migrated into client and server files in the Discourse repo where the English versions are these:
discourse/client.en.yml at master · discourse/discourse · GitHub
discourse/server.en.yml at master · discourse/discourse · GitHub

This topic covers this in more detail:

Note that there is a whole dates section in each of these files which comes from Transiflex:

github.com

discourse/discourse/blob/master/config/locales/client.en.yml#L39-L65


dates:
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  time: "h:mm a"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  timeline_date: "MMM YYYY"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_no_year: "MMM D h:mm a"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_no_year_no_time: "MMM D"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  full_no_year_no_time: "MMMM Do"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_with_year: "MMM D, YYYY h:mm a"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_with_year_no_time: "MMM D, YYYY"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  full_with_year_no_time: "MMMM Do, YYYY"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_date_with_year: "MMM D, 'YY LT"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/

This file has been truncated. show original

github.com

discourse/discourse/blob/master/config/locales/server.en.yml#L18-L44


dates:
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  short_date_no_year: "D MMM"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  short_date: "D MMM, YYYY"
  # Use Moment.js format string: http://momentjs.com/docs/#/displaying/format/
  long_date: "MMMM D, YYYY h:mma"


datetime_formats: &datetime_formats
  formats:
    # Format directives: http://ruby-doc.org/core-2.3.1/Time.html#method-i-strftime
    short: "%m-%d-%Y"
    # Format directives: http://ruby-doc.org/core-2.3.1/Time.html#method-i-strftime
    short_no_year: "%B %-d"
    # Format directives: http://ruby-doc.org/core-2.3.1/Time.html#method-i-strftime
    date_only: "%B %-d, %Y"
    # Format directives: http://ruby-doc.org/core-2.3.1/Time.html#method-i-strftime
    long: "%B %-d, %Y, %l:%M%P"
date:
  # Do not remove the brackets and commas and do not translate the first month name. It should be "null".

This file has been truncated. show original

Again hopefully someone with more knowledge will correct me if wrong…

As I see it you should submit the "jYYYY etc translations to Discourse localization

Moment.js will then be called with the right “jYYYY” etc instead of “YYYY”

Then you need to submit two extra code patches / Pull Requests to Discourse to add and call the extra libraries as needed:

One Pull Request to add and load moment-jalaali if, an only if “jYYYY” etc are used.
2nd Pull Request for handling any dates etc which are handled via Ruby.

Following the translation and then first pull request should get you most of the way there.

One of the Discourse team will read this at some point (they read everything here) and may comment on if this is acceptable or if they have a better idea for a way forward.

l3est · 2017-05-07 06:41:31 UTC

Thanks for all the information. I think plugin would be better for this problem.
if I add the jYYYY to translation files, it won’t parse correctly.
jYYYY jMM jD will turn into j2017 jMay j7

still and the main question is, how to add moment-jalaali.js to formatter.js.es6 (ECMA Script 6 file) ?

codinghorror · 2017-05-07 09:02:28 UTC

codinghorror · 2017-05-08 15:00:06 UTC

This topic was automatically opened after 29 hours.

satoshi_download · 2018-07-16 08:08:40 UTC

Hi
How to change the processmaker 3.2 environment to Hijri or Jalali Calendar?
The processmaker has been used by Moment.js , I want to use moment-jalaali.js.
for example : I want use Jalali Calender in “Inbox,Draft,Participation,Last Modified,Due Date,Summeary,…”

sam · 2018-07-16 08:32:06 UTC

@Osama any ideas about what we should offer here?

Osama · 2018-07-17 06:33:10 UTC

It looks like there are moment.js plugins for Hijri and Jalali calenders: Moment.js | Docs

To see how easy it’s to use, I cloned the Hijri plugin into vendor folder and changed the dates formats in client.ar.yml according to the plugin documentation and I got it to display Hijri dates in a few places:

(July 2017 is in 1438 Hijri year)

I’m guessing it didn’t display Hijri dates in all places because those were using different core methods for displaying dates and might need to be tweaked a bit to display Hijri dates correctly.

Overall I think Hijri support should be done in a plugin and in a new separate Arabic locale to let people choose between Hijri or Gregorian.

gerhard · 2018-07-17 09:38:37 UTC

The plugin could either create a new locale that falls back to the existing Arabic locale or it could simply override the existing locale. In either case, the locale files in the plugin would only need to contain the new date formats. See: Add a new locale from plugin