HTML diffs and images


(Michael Howell) #1

How come the most recent change in https://forum.bors.tech/t/adding-new-reviewers-to-a-repository/73 shows the images as being changed, when the raw diff shows that they aren’t being changed?




(Jeff Atwood) #2

I think this is a technically hard problem to deal with, and the benefits are so minor (arguably cosmetic only) that we’re loathe to burn a week of engineering time on it. cc @zogstrip – this also might be a dupe topic.


(Michael Brown) #3

As far as the why it’s to do with how the post was baked for version 2 - back in 2017/11 the baking code put in:

<img src="//forum.bors.tech/uploads/default/optimized/1X/c5778e339bb03ad220076e342a86b05ecf95964d_1_352x500.PNG" alt="On a small screen, the Repositories button is under your user menu" width="352" height="500">

for the LHS and the new version does:

<img src="https://forum.bors.tech/uploads/default/optimized/1X/c5778e339bb03ad220076e342a86b05ecf95964d_1_352x500.PNG" alt="On a small screen, the Repositories button is under your user menu" width="352" height="500">

for the RHS.

It could be that e.g. SSL was forced in between those two dates.


(Michael Howell) #4

Yeah, I think that is what happened. Thanks for the info!