How come the most recent change in https://forum.bors.tech/t/adding-new-reviewers-to-a-repository/73 shows the images as being changed, when the raw diff shows that they aren’t being changed?
AI-generated summary
A discussion about HTML diffs and images is ongoing. notriddle noticed that an unchanged image appears as modified in a diff, displaying the images as changed. codinghorror believes this is a technically challenging problem and not a priority, considering the benefits minor. supermathie explained that the issue is due to a change in the baking code between 2017 and the current version, specifically the addition of HTTPS in the image source. notriddle agreed with this explanation, and sam decided to close the discussion, suggesting that image diffs are not a feasible feature request at this time.
I think this is a technically hard problem to deal with, and the benefits are so minor (arguably cosmetic only) that we’re loathe to burn a week of engineering time on it. cc @zogstrip – this also might be a dupe topic.
1 Like
As far as the why it’s to do with how the post was baked for version 2 - back in 2017/11 the baking code put in:
<img src="//forum.bors.tech/uploads/default/optimized/1X/c5778e339bb03ad220076e342a86b05ecf95964d_1_352x500.PNG" alt="On a small screen, the Repositories button is under your user menu" width="352" height="500">
for the LHS and the new version does:
<img src="https://forum.bors.tech/uploads/default/optimized/1X/c5778e339bb03ad220076e342a86b05ecf95964d_1_352x500.PNG" alt="On a small screen, the Repositories button is under your user menu" width="352" height="500">
for the RHS.
It could be that e.g. SSL was forced in between those two dates.
6 Likes
Yeah, I think that is what happened. Thanks for the info!
1 Like
Sorry, not sure I want to keep this open, we are unlikely to make any changes here and there was … technically… a legitimate change with the image.
Image diff would be a warmcan of a feature request.
2 Likes