Impossible de désactiver les embeddings IA lorsque les modèles ont été supprimés

RGJ · Août 24, 2025, 4:34

Create AI embedding models
Enable AI embeddings enabled
…
Remove models
Try to disable AI embeddings enabled

This is impossible. When disabling, the error ai_embeddings_enabled: Set ‘ai embeddings selected model’ first appears.

Expected: this should only trigger when the setting is switched from off to on, not from on to off.

Or better: don’t allow to remove all models if the setting is enabled.

sam · Août 24, 2025, 11:31

@Roman can you have a quick look at this, looks like an easy fix.

Roman · Août 25, 2025, 5:56

I couldn’t reproduce the bug. Am I missing something?

We don’t run any validations when disabling ai_embeddings_enabled, only when enabling we validate ai_embeddings_selected_model is set:

github.com/discourse/discourse

plugins/discourse-ai/lib/configuration/embeddings_module_validator.rb

main


      
          # frozen_string_literal: true
          
          module DiscourseAi
            module Configuration
              class EmbeddingsModuleValidator
                def initialize(opts = {})
                  @opts = opts
                end
          
                def valid_value?(val)
                  return true if val == "f"
                  return true if Rails.env.test?
          
                  SiteSetting.ai_embeddings_selected_model.present?
                end
          
                def error_message
                  I18n.t("discourse_ai.embeddings.configuration.choose_model")
                end
              end

Also, we won’t let you delete the embedding config if it’s the currently selected model:

github.com/discourse/discourse

plugins/discourse-ai/app/controllers/discourse_ai/admin/ai_embeddings_controller.rb

main


      
          
          def destroy
            embedding_def = EmbeddingDefinition.find(params[:id])
          
            if embedding_def.seeded?
              return(
                render_json_error(I18n.t("discourse_ai.embeddings.cannot_edit_builtin"), status: 403)
              )
            end
          
            if embedding_def.id == SiteSetting.ai_embeddings_selected_model.to_i
              return render_json_error(I18n.t("discourse_ai.embeddings.delete_failed"), status: 409)
            end
          
            embedding_details = {
              embedding_id: embedding_def.id,
              display_name: embedding_def.display_name,
              provider: embedding_def.provider,
              dimensions: embedding_def.dimensions,
              subject: embedding_def.display_name,
            }

RGJ · Août 25, 2025, 7:04

I can’t reproduce anymore either, weird. Feel free to close this.

Sujet		Réponses	Vues
Can´t set ai embedding model Support ai	4	72	Juillet 16, 2025
Can't change ai_embeddings_model Bug ai , fixed	5	90	Décembre 25, 2024
Problems with Discouse AI embeddings configuration Bug ai	7	95	Janvier 31, 2025
AI helper model site setting is hidden now but still in use Bug ai	2	56	Juillet 16, 2025
Discourse AI Gemini Embeddings Failing to Enable, But Other Features Work Fine Support ai	2	75	Novembre 7, 2024

Impossible de désactiver les embeddings IA lorsque les modèles ont été supprimés

Sujets connexes