After submitting this PR I discovered an inconsistency with watching first post that I am not sure how to resolve. Watching first post exists in two primary locations: the notification level dropdown on category pages, and the user preferences page. The User Preferences page appears to be a handl…

Perhaps @eviltrout can comment, this was his feature as I recall?

I looked into making a PR but that’s when I ran into the inconsistency… If I change line 12 in the JavaScript so that the key uses hyphens not underscores under - that will change the CSS class but also break translations. Are you OK with me changing the client-en.yml file so it also uses hyphens…

No, I definitely would not want to rename our translation keys for this. I’m okay with dashes everywhere in our codebase for this feature except for the CSS. I’ve changed it here: https://github.com/discourse/discourse/commit/f42b6054e6588a37a91b48087d91075351ed2b77 The class name should use dashe…

Thanks Robin - I wouldn’t have had a clue where to start to fix this one. Have a :gift_heart:!

Inconsistency in code for watching first post

Development

eviltrout (Robin Ward) 31. März 2017 um 14:53 3

Hyphens are definitely the way to go for CSS classes. Are you comfortable making a PR for this? If not I can fix it.

Thema		Antworten	Aufrufe
Make category notification choices language consistent UX	0	400	12. April 2021
Set watch_first_post via API? Development rest-api	2	978	4. Januar 2020
Can't disable "Watching first post" Bug	4	1458	2. August 2016
Actual difference between "tracked" and "watching first post" Product Support	28	10764	15. Dezember 2018
Following on from Adding Unique Class Names Feature	19	4914	15. Januar 2016

Inconsistency in code for watching first post

Verwandte Themen