Ho trovato un piccolo bug durante il caricamento di un file:
Se il file inizia e finisce con un trattino basso (_test_file_.txt in questo caso), il codice di generazione del markup non fa l’escape del trattino basso, risultando nel seguente “nome file”:test_file .txt|attachment
[_test_file_.txt|attachment](upload://eSJGButIpkpu4IEifmmispiFRJu.txt) (23 Byte)
Se faccio l’escape del primo trattino basso con una barra rovesciata, viene analizzato correttamente:
_test_file_.txt (23 Byte)
[\_test_file_.txt|attachment](upload://eSJGButIpkpu4IEifmmispiFRJu.txt) (23 Byte)
2 Mi Piace
Grazie per la segnalazione @ValdikSS
main ← fix/escape-markdown-in-upload-filenames
opened 02:33PM - 07 Apr 26 UTC
Filenames containing markdown formatting characters (`_`, `*`, `~`, `` ` ``, `[`… , `]`, `|`) would break upload markup when cooked. For example, uploading `_test_file_.txt` generated:
[_test_file_.txt|attachment](upload://...)
The underscores triggered emphasis parsing inside the link text, which both rendered the filename incorrectly (with italics) and prevented the `|attachment` marker from being recognized — losing the `class="attachment"` on the resulting `<a>` tag.
**Markdown generation (defense in depth)**
Add `escapeMarkdownCharacters` (JS) and `UploadMarkdown.escape_markdown` (Ruby) to backslash-escape all inline formatting characters in filenames before embedding them in markdown link text. Applied in:
- `UploadMarkdown` — image, attachment, and playable media methods
- `uploads.js` — `attachmentMarkdown` and `markdownNameFromFileName`
- `inline_uploads.rb` — HTML anchor conversion and hotlinked image URLs
- `to-markdown.js` — HTML-to-markdown attachment link reconstruction
- `sanitizeAlt` in `markdown-image-builder.js` — image alt text
**Parser resilience (belt and suspenders)**
The markdown-it `renderAttachment` renderer and ProseMirror's link parser both assumed `tokens[idx+1]` was a single text token containing the full link text. When emphasis/bold/strikethrough/code was parsed inside the link text, the token sequence included formatting tokens and the `|attachment` marker was lost. Both now scan forward through all tokens between `link_open` and `link_close` to find the marker.
The image renderer (`renderImageOrPlayableMedia`) split alt text on `|` assuming the first segment was always the alt and everything after was structured suffixes (dimensions, video/audio, data attributes). A pipe in the filename would produce extra segments that confused the dimension parser. It now scans from the right, consuming known suffixes, and treats everything remaining as alt text.
https://meta.discourse.org/t/400079
1 Mi Piace
Ecco un tentativo di risolvere questo problema una volta per tutte