i don’t know if this is an issue regarding Discourse exactly or if it’s coming from twitter API but I wanted to share this little bug, when we share a tweet from a account that has a underscore in its username, the link is broken on Discourse, here is an example :
Then it’s something @sam will have to add to his list for later. In the meantime, replace the underscore with the URL-encoded version of the character.
It’s possible to fix, but not easy. Workaround available.
Correct solution is to make linkifier part of tokenizer process. That’s expensive (for example, email lookahead check for every character). Tradeoff is to listen : then do look behind for http(s), and lookahead for the rest. That’s not universal, but will cover all real cases:
http/https links will be parsed with other tokens, with higher priority than emphasis
everything else will be detected via text scan & regexps (as linkifier works now), probability of collision is very low.
I have no plans to do this, but if anyone wish to implement - see explanation above. Or use < >
Potremmo risolvere questo problema eseguendo il lavoro nel nostro gestore di incolla e, se incolliamo un URL, codificando in percentuale i trattini bassi nella stringa di query?
Non sono d’accordo; https:// è un insieme di caratteri così raro che penso che manipolarlo sia di solito abbastanza sicuro.
(Tranne nei blocchi di codice, quindi c’è questo, ma se gli appunti sono SOLO UN URL, allora è abbastanza sicuro secondo me. Quindi se facessi un’ancora di “inizia con https://” posso garantire al 99,99% che sarà sicuro.)
