Generazione errata del markup dell'allegato con underscore nel nome del file

zogstrip · 7 Aprile 2026, 2:33pm

Grazie per la segnalazione @ValdikSS Ecco un tentativo di risolvere questo problema una volta per tutte

github.com/discourse/discourse

FIX: Escape markdown characters in upload filenames (#39133)

main ← fix/escape-markdown-in-upload-filenames

opened 02:33PM - 07 Apr 26 UTC

ZogStriP

+159 -58

Filenames containing markdown formatting characters (`_`, `*`, `~`, `` ` ``, `[`…, `]`, `|`) would break upload markup when cooked. For example, uploading `_test_file_.txt` generated: [_test_file_.txt|attachment](upload://...) The underscores triggered emphasis parsing inside the link text, which both rendered the filename incorrectly (with italics) and prevented the `|attachment` marker from being recognized — losing the `class="attachment"` on the resulting `<a>` tag. **Markdown generation (defense in depth)** Add `escapeMarkdownCharacters` (JS) and `UploadMarkdown.escape_markdown` (Ruby) to backslash-escape all inline formatting characters in filenames before embedding them in markdown link text. Applied in: - `UploadMarkdown` — image, attachment, and playable media methods - `uploads.js` — `attachmentMarkdown` and `markdownNameFromFileName` - `inline_uploads.rb` — HTML anchor conversion and hotlinked image URLs - `to-markdown.js` — HTML-to-markdown attachment link reconstruction - `sanitizeAlt` in `markdown-image-builder.js` — image alt text **Parser resilience (belt and suspenders)** The markdown-it `renderAttachment` renderer and ProseMirror's link parser both assumed `tokens[idx+1]` was a single text token containing the full link text. When emphasis/bold/strikethrough/code was parsed inside the link text, the token sequence included formatting tokens and the `|attachment` marker was lost. Both now scan forward through all tokens between `link_open` and `link_close` to find the marker. The image renderer (`renderImageOrPlayableMedia`) split alt text on `|` assuming the first segment was always the alt and everything after was structured suffixes (dimensions, video/audio, data attributes). A pipe in the filename would produce extra segments that confused the dimension parser. It now scans from the right, consuming known suffixes, and treats everything remaining as alt text. https://meta.discourse.org/t/400079

Argomento		Risposte	Visualizzazioni
Some links are misinterpreted Bug	7	725	Agosto 8, 2022
Links broken with (at least) two underscores in URL Bug	9	2054	Giugno 15, 2022
Links with underbars surrounded by hyphens render incorrectly Bug	2	760	Settembre 24, 2018
A comma followed by an underscore in a URL results in defunct link Bug markdown-it-review	6	2827	Giugno 26, 2017
Underscores in a URL are being interpreted as Markdown, the link fails to work Bug	2	750	Novembre 2, 2019

Generazione errata del markup dell'allegato con underscore nel nome del file

Argomenti correlati