📢 기본 채팅 채널 도입 (사용자 자동 추가)

[mcwumbly (Dave McClure)]

@alehandrof

What remains unclear to me is whether this check is run periodically. In other words, if a previously inactive user interacts with the site tomorrow will they automatically join the chat channel or not?

Yep, the job runs every hour and should cover this scenario.

@alehandrof

I understand from this thread that only “active” users join the channel. That’s fine – though the label on the option should be updated to more accurately describe the feature.

Definitely open to suggestions to improve the copy here to make this part more clear!

[alehandrof (Alex Armstrong)]

@mcwumbly

Definitely open to suggestions to improve the copy here to make this part more clear!

Well, the current copy is “Automatically add all new and existing users”, which is clearly false.

How about “Automatically add users who [whatever the criteria are]”?

[mcwumbly (Dave McClure)]

Here’s a first pass:

https://github.com/discourse/discourse-chat/pull/1236

[davidkingham]

Check hourly which users have been active in the last 3 months. Add them to this channel if they have access to the Beginners Feedback category.

Could I get some clarification on what ‘access’ means exactly? I have a category where everyone can see, but only certain groups can create or reply. It seems to me that the users who can only see shouldn’t be added to the channel automatically, and shouldn’t be able to participate at all in that channel until they are in the group. Maybe it works this way already, but I want to make sure before moving forward. Thanks!

[mcwumbly (Dave McClure)]

As of December, “reply” permission is required to be able to join (access) a channel:

https://github.com/discourse/discourse/pull/19488

So I believe this now works as you’d like it to work for your scenario.

[davidkingham]

Thanks Dave, that is how I would like it to work, unfortunately I just tried it and it doesn’t work that way. I have my category set up like this:

The Beginners group only has 2 members right now, the Beginner_Support group has 12. The channel after turning on Automatically add users now has 774 members, which is probably about the right amount of active users for everyone…

[mcwumbly (Dave McClure)]

OK, yep, that doesn’t look like what I’d expect at this point. I’ll take a look tomorrow and let you know what I find.

[mcwumbly (Dave McClure)]

@mcwumbly

I’ll take a look tomorrow and let you know what I find.

I do see the issue you’re seeing here. I still need to spend a bit more time tinkering to understand the details of what is and isn’t working properly so we can get something queued up to address this.

[mcwumbly (Dave McClure)]

OK, here’s what I’m seeing for a user “Bob” who only has “See” access to the category for the channel:

1. I do see Bob in the members list (unexpected)
2. Bob does not see the channel in the sidebar initially (ok)
3. Bob does not see the channel in /chat/channels/browse (ok)
4. Bob does see the channel if he visits /chat/c/${channelname}/${id} (unexpected)
5. Bob does see notifications when someone mentions him in the channel (unexpected)
6. Bob does see the channel in his sidebar once he gets a mention or posts in the channel after visitng it directly (unexpected)

Will add this to our list to fix up.

[mcwumbly (Dave McClure)]

We merged the following pull requests which should address this issue:

https://github.com/discourse/discourse/pull/20213

https://github.com/discourse/discourse/pull/21700

Initially, we had planned to allow read-only users to preview chat channels, but designing the user experience for that turned out to be a bit more complicated than we originally anticipated, so we removed that feature for now in the name of simplicity.

Note: if you had channels set up with auto-join that included groups with read-only permissions, you may need to edit the channel settings once to force the membership list to synchronize with these new rules.

[davidkingham]

That works brilliantly, thank you Dave!