Moin
24. Juli 2025 um 10:08
41
main ← dev/use-themeable-site-settings-horizon
opened 06:30AM - 16 Jul 25 UTC
This commit removes the value transformers introduced
to Horizon back in https:… //github.com/discourse-org/nextgen-theme/commit/274e5f7a1f15e1244ce7039913036501d76ef8dc
and https://github.com/discourse/discourse/commit/897d34132e8f323ca42dbfbd377f539761440d09
in favor of the new themeable site settings introduced in
19af83d39e6c06cdc31df2c203623b47bef9c252 , as this is what they
are for.
No migration for existing sites...they will already have
ThemeSiteSetting values from a previous migration to ensure
site setting values were preserved in theme site settings.
We do delete the ThemeField storing the Horizon custom theme
setting definition though, otherwise the UI still shows the old settings.
<img width="1170" height="969" alt="image" src="https://github.com/user-attachments/assets/96654138-b59b-4809-8b98-e722fac99202" />
Fortunately, I waited patiently for an update. I thought for a while about whether I should simply create a pull request to move the texts. That would obviously have been a waste of time
1 „Gefällt mir“