Link dissapears when mini-onebox fails

bug
1

I’m not sure if the problem is specific with Linkedin or is also present with other sites, however:

Raw:

https://www.linkedin.com/company/fcagroup
(from https://www.linkedin.com/company/fcagroup)

https://www.linkedin.com/
(from https://www.linkedin.com/)

https://www.linkedin.com/in/kyle-park-254a?trk=org-employees_mini-profile_cta
(https://www.linkedin.com/in/kyle-park-254a?trk=org-employees_mini-profile_cta)

Results:

https://www.linkedin.com/company/fcagroup
(from https://www.linkedin.com/company/fcagroup)


(from https://www.linkedin.com/)

https://www.linkedin.com/in/kyle-park-254a?trk=org-employees_mini-profile_cta
(https://www.linkedin.com/in/kyle-park-254a?trk=org-employees_mini-profile_cta)

No JS error in the browser console, however the link title is skipped:

I can repro only here on Meta both on Firefox and Chrome, the other sites are not yet affected by this problem.

4 Likes
2

@sam could this be a regression from your mini-onebox timeout fix?

3

I believe this is working as expected, since this link returns 999 Request denied and some HTML without a title.

EDIT: Oh I see, the bug is that we don’t fallback to just the link when mini-onebox fails, in some conditions.

3 Likes
7

I see what is happening here, fixed per:

https://github.com/discourse/discourse/commit/f946db4afe5af02539437ed221893cf1362fb6db

5 Likes