My users reported the issue…I reproduced the issue with Chrome 66.0.3359.181
Issue shows even with default or empty list.
In which section would this be added?
have you checked the link? here is it again:
https://github.com/jrgong420/discourse-linkify-words/commit/0d4b55ac72e2ee9b59bd1f0cf7304284abd69f00
As you can see, the code was added to common/head_tag.html file right after line 36.
I am having another issue (unrelated to the one above, since I downgraded back to 2.0 stable):
It seems that the ~ character in URLs breaks links generated by linkify.
I tried to escape it like this: \~. but then the output is /~.
Any ideas?
Yeah where exactly is that file to place it? looking thru /var/ I couldnt see anything and not not that experienced with docker.
Under themes, common in the head section I dont seen any file where I can place it after line 36.
just copy the theme component to your own github repo and make the change there.
then you can install the theme from git. check the link in the first post. it’s all documented
2 Likes
Ah makes sense. Thank you!
I was able to resolve the issue myself.
Solution: urlencode the special character(s) or even the whole URL on a site like https://www.url-encode-decode.com/
So the ~ becomes a %7E in the URL. That way the link will be added in the correct manner.
It seems that linkify is not able to detect phrases e.g. when they are surronded by special characters like brackets (). Anyone have an idea how to fix that?
I have an experience building such feature, on Drupal (word_link module) websites and then in an SPA (word-link lib) websites.
The way it currently works, I have a spreadhead on Google docs with words and links. Google docs have a possibility to share documents as CSV files.
On a website, you have a js file which requests that Google Docs Spreadsheet, and replaces text with given links using word-link lib.
Benefits of that method are, you get for free a sort of links management page with access settings, so you can let only a few people edit it. And google caches it for you.
As a downside, you may need to write your own CORS proxy for that.
JavaScript code on a client will look like below:
const text = 'foo bar baz';
const words = [
{
text: 'foo',
url: 'https://foo.com'
}
];
function replace(text, words) {
return words.reduce(function(text, word) {
return WordLink.apply(text, word.text, word.url)
}, text);
}
console.log(replce(text, words)); // "<a href="https://foo.com">foo</a> bar baz"
2 Likes
That is awesome!
How hard/easy is it to implement something similar to linkify?
By the first look on https://github.com/discourse/discourse-linkify-words/blob/master/common/head_tag.html It looks like you need to replace middle part of a script.
- Attach word-link script, so
WordLinkmodule is available in a scope. - Get words to be replaced from
settings.linked_wordsvariable. - Apply
WordLinkto the text like the following:
const linkify = function(element) {
const newElement = element.cloneNode(true);
newElement.innerHTML = WordLink.apply(element.innerHTML, word, url);
return newElement;
};
api.decorateCooked(linkify);
I haven’t tested the code, it may require some corrections.
2 Likes
Hi there! There is a small limitation in this otherwise awesome theme. If the word is preceded or followed by parentheses, it will not be matched.
@sam thinks this is a reasonable thing to fix, providing there is not a catch 
1 Like
Yes, this would be an improvement for us, as well.
We do have a very active user who uses square brackets rather than parenthesis, so I’d vote for them, too.
What about end-of-sentence punctuation? I’ve found times when I’ve had to restructure sentences so a period, question mark or exclamation point doesn’t spoil the magic.
Like here, where I wanted to simply ask, “Could you try operating the phone in Safe Mode?”
Still loving this theme, by the way, and thank you for asking!
3 Likes
Btw: need to add quotation and exclamation marks as well…
1 Like
Period should already work. Just noticed the problem with ? and ! as well, but you were quicker.
1 Like
Ha! You’re right. I’ve been avoiding them out of an over-abundance of caution.
I’ve been thinking of creating a glossary in our forum, and this seems like a great way to make it actually useful. I’m wondering how others may have implemented glossaries for their forum? Did you put each word onto it’s own topic? The entire glossary into a single topic? Something else?
1 Like
Excuse my lack of context but why not just RegExp("(\\b)" + escapedWords + "(\\b)", "ig")
This could work… I guess we don’t want _test_ to be linked.
@danekhollas feel free to send in a PR for the component looks like the consensus is that it makes sense to add more stuff. I guess I support ([{}])?;!
5 Likes