i don’t know if this is an issue regarding Discourse exactly or if it’s coming from twitter API but I wanted to share this little bug, when we share a tweet from a account that has a underscore in its username, the link is broken on Discourse, here is an example :
Then it’s something @sam will have to add to his list for later. In the meantime, replace the underscore with the URL-encoded version of the character.
It’s possible to fix, but not easy. Workaround available.
Correct solution is to make linkifier part of tokenizer process. That’s expensive (for example, email lookahead check for every character). Tradeoff is to listen : then do look behind for http(s), and lookahead for the rest. That’s not universal, but will cover all real cases:
http/https links will be parsed with other tokens, with higher priority than emphasis
everything else will be detected via text scan & regexps (as linkifier works now), probability of collision is very low.
I have no plans to do this, but if anyone wish to implement - see explanation above. Or use < >
¿Podríamos solucionar esto haciendo el trabajo en nuestro manejador de pegar y, si estamos pegando una URL, codificar porcentualmente los guiones bajos en la cadena de consulta?
No estoy de acuerdo; https:// es un conjunto de caracteres TAN raro que creo que jugar con él suele ser bastante seguro.
(Excepto en los bloques de código, así que existe esto, pero si el portapapeles es SÓLO UNA URL, entonces es bastante seguro en mi opinión. Así que si hicieras una ancla de “empieza con https://” te garantizo al 99,99% que será seguro.)
