A discussion is ongoing about broken links in Discourse when URLs contain at least two underscores. Steven shared examples of broken Twitter links with underscores, while codinghorror suggested using angle brackets to fix the issue, although this prevents oneboxing.
Steven found a temporary solution by replacing underscores with the URL-encoded version %5F. sam suggested reporting the issue to markdown.it for linkify, but Vitaly mentioned it’s a known issue with a workaround available.
sam asked if Vitaly has revisited the issue, and supermathie proposed fixing the issue by percent-encoding underscores in the query string in the paste handler. However, sam expressed concerns about fiddling with the clipboard. codinghorror disagreed, suggesting that fiddling with the clipboard is safe when dealing with URLs starting with https://.
i don’t know if this is an issue regarding Discourse exactly or if it’s coming from twitter API but I wanted to share this little bug, when we share a tweet from a account that has a underscore in its username, the link is broken on Discourse, here is an example :
Then it’s something @sam will have to add to his list for later. In the meantime, replace the underscore with the URL-encoded version of the character.
It’s possible to fix, but not easy. Workaround available.
Correct solution is to make linkifier part of tokenizer process. That’s expensive (for example, email lookahead check for every character). Tradeoff is to listen : then do look behind for http(s), and lookahead for the rest. That’s not universal, but will cover all real cases:
http/https links will be parsed with other tokens, with higher priority than emphasis
everything else will be detected via text scan & regexps (as linkifier works now), probability of collision is very low.
I have no plans to do this, but if anyone wish to implement - see explanation above. Or use < >
Можно ли исправить это, выполнив работу в нашем обработчике вставки и, если мы вставляем URL, кодируя символы подчеркивания в строке запроса с помощью процентного кодирования?
Я не согласен; https:// — это НАСТОЛЬКО редкая комбинация символов, что, на мой взгляд, такие манипуляции обычно вполне безопасны.
(За исключением блоков кода, но если в буфере обмена ТОЛЬКО URL, то это, по моему мнению, довольно безопасно. Так что, если вы создадите якорь «начинается с https://», я могу на 99,99% гарантировать, что это будет безопасно.)
