Locations Plugin

merefield · January 28, 2022, 7:00pm

Sorry I’m not clear what is causing that. Locations plugin on its own will not corrupt the website link.

Are you saying when the Custom Wizard is also installed you get that duplication?

4ong · January 28, 2022, 10:20pm

Hmm, thanks. Don’t know why this is happening yet - will try to investigate tomorrow.
Here is what it shows right now with -

Andorra is the text from user profile location field when Location plugin is deactivated.
And the screen shows what happens when Location plugin is activated.

P.S. It’s can be my fault with some settings or plugins - do not waste too much time on this - I will investigate it step-by-step

4ong · January 28, 2022, 10:22pm

Are you saying when the Custom Wizard is also installed you get that duplication?
No - I’ve tried with and without Custom Wizard - duplicate stays.

The question about Custom Wizard is - how it’s possible to update user location in user profile from the Wizard?
I’ve tried location field there - but with no success.
Should I ask this in Custom Wizard topic?

Cheers,

merefield · January 28, 2022, 10:25pm

I cannot reproduce your issue so would appreciate if you can track down any clash. Locations is working fine with web page details for me.

4ong · January 28, 2022, 10:26pm

Sure, I will investigate tomorrow. Thanks!

Canapin · January 28, 2022, 11:47pm

My profile doesn’t appear on the users map: https://unicyclist.com/u/user-map?period=location (I should be in France)

I thought it was because my location in my profile wasn’t precise enough (just “France”), so I updated it using the autocompletion, but my icon still doesn’t appear on the map.

Any idea why?

omarfilip · January 29, 2022, 3:06am

Check the setting location users map limit. If it’s lower than the number of users who have added their location, the ones after the limit number will not be shown on the map.

Canapin · January 29, 2022, 10:51am

That was it. Thanks.

Canapin · February 13, 2022, 12:48pm

Some of my users encounter a rate limit with the default provider (nominatim) that makes them wait one minute before trying again.

Weirdly, I don’t come across any kind of limit.

See: The location field in profile is kind of broken - Forum Feedback - Unicyclist.com

Any idea why I don’t encounter any limit whereas some users encounter it? I tried writing long locations’ names while typing fast.
What would be your second choice for the location_geocoding_provider setting (for a free usage)?
What’s the location_geocoding_debounce setting?

I see that in nominatim’s usage policy that “Auto-complete search This is not yet supported by Nominatim and you must not implement such a service on the client side using the API.”

There is no auto-completion in the location button on a new topic, but there is one in the custom user field:

chrome_tOtNSZ2dXy

Is this a forbidden usage?

Jagster · February 13, 2022, 3:26pm

Yes, and no. Mostly no. It can be against GDPR, if the location comes automatically without user’s action AND the site is driven by a company or community, meaning not a private person, AND it is not needed.

But… geo-location is really unaccurate. I don’t know how things are in France but in Finland all operators act countrywide so every time my IP changes, changes my location and everytime it points to wrong city.

And IP is not considered as personal data, but more or less as public data that cannot use to identify a single person.

But in use of the plugin geo-location isn’t forbidden, prohibited or unlegal, because an user wants to show it. And using IP as source of location is never unlegal.

There can be some more moral issues, though. But it depends of forum.

Canapin · February 13, 2022, 6:05pm

I may misunderstand how the plugin works actually. I’ll have to read all this topic. Thanks for your reply.

angus · February 13, 2022, 11:32pm

You can only use Nominatim for testing. For production use I would recommend

Richie · February 28, 2022, 2:00pm

Just following this up from last month, apologies, I’d somehow missed any notifications to replies

Our other site, which is displaying the larger text is using Leaflet v1.5.1

I see the Locations plugin was 1.3.4 and is now 1.7.1, which means the version isn’t an issue.

Agreed.

Just to remind people, the text is so small on our Locations map that it’s unreadable.

Example with screen shots here: Locations Plugin - #736 by Richie

Thanks Robert @merefield yes I do have access to the source of the other site where the text is larger but on the same basemap.

The difference I believe is that there is an additional parameter being passed:

tileSize: 512

It’s applied in this context:



// Attribution
var mbAttr = 'Map &copy; <a href="https://www.openstreetmap.org/">OpenStreetMap</a>, Imagery © <a href="https://www.mapbox.com/">Mapbox</a>, Content &copy; <a href="https://GreyArro.ws/">Grey Arrows Drone Club</a>',
	mbUrl = 'https://api.mapbox.com/styles/v1/mapbox/{id}/tiles/{z}/{x}/{y}?access_token=<%=Variabs.GlobalVariables.strOpenStreetMapKey%>',
	mbMaxZoom = '20'
;


// Basemaps
var
	// Full list: https://gis.stackexchange.com/a/244797/145060
	// Full list: https://docs.mapbox.com/help/troubleshooting/migrate-legacy-static-tiles-api/#which-classic-styles-are-being-deprecated
	// Full list: https://docs.mapbox.com/api/maps/#mapbox-styles
	dark = L.tileLayer(mbUrl, { id: 'dark-v10', maxZoom: mbMaxZoom, attribution: mbAttr, tileSize: 512, zoomOffset: -1 }),
	road = L.tileLayer(mbUrl, { id: 'outdoors-v11', maxZoom: mbMaxZoom, attribution: mbAttr, tileSize: 512, zoomOffset: -1 }),
	satellite = L.tileLayer(mbUrl, { id: 'satellite-v9', maxZoom: mbMaxZoom, attribution: mbAttr, tileSize: 512, zoomOffset: -1 }),
	hybrid = L.tileLayer(mbUrl, { id: 'satellite-streets-v11', maxZoom: mbMaxZoom, attribution: mbAttr, tileSize: 512, zoomOffset: -1 })
;

Therefore, I think I have a feature request

Please can we add a tileSize to the plugin settings?

Unless I can somehow pass the desired tilesize in the Map tile layer uri setting?

dodesz · May 20, 2022, 1:43pm

Hello,

I noticed an issue with composer location button I think.
Discourse version a6abf8d07a

Thank you

merefield · May 20, 2022, 4:43pm

Thanks @dodesz I can repro, although it doesn’t seem to stop the show, I’ll take a look v soon

merefield · May 21, 2022, 8:21am

It’s due to a breaking change from this commit in core: FIX: Use CSS transition to make room for composer (#16750) · discourse/discourse@9ea8a4a (github.com)

I’ve pushed a fix together with some minor formatting tweaks to improve the L&F:

dodesz · May 21, 2022, 9:05am

Thank you Robert I am really appreciate you fix this so quickly out of maintenance time. I will update soon and update this post as well how it works.

Works fantastic thanks again!

Ben_Evans · June 14, 2022, 4:38am

Hi. Anyone know if it’s possible somehow to add a location to a map by dropping a pin with this plugin?

The locations of some communities are in places that are hard to identify without the use of coordinates, which might put some users off adding a location. Thanks!

merefield · June 14, 2022, 6:35am

I was sure someone requested this before but it’s not on the current list afaics.

Feature requests can be made here: Feature Request

But please note we are usually busy enough maintaining the plugins that new features are rare without someone sponsoring the work.

We would also welcome PRs. This is an especially good feature to add.

dodesz · July 4, 2022, 9:48am

Hello,

I noticed an issue with location under topic title. If a user remove a previously added location from /preferences/profile
Then it will show an empty location under topic title instead of remove it.

Screenshot 2022-07-04 at 11.41.30

Thank you