Locations Plugin

[packman (Chris McMahon)]

I’m just retesting a previously reported problem that it was thought had been fixed. Apologies for going back a month…little things like getting married, dog-sitting for a few weeks and an overseas visitor have kept me busy!

1. Set location topic default to User
2. Set a location for your user (if you don’t already have one)
3. Add a topic in a location enabled category. The topic gets your location and appears on the topic map with any other relevant markers.
4. Delete your user location
5. Add a topic to the same category as in (3). The topic doesn’t get your location (as you’d expect), but when you display the topic map all markers are missing.
6. Set location topic default to None - all markers reappeared on the topic map…initially. However, when viewing the user map there were no markers and after going back to the topic map all those markers have now disappeared again. I’ve tried deleting the two posts from (3) and (5), setting Location Topic Default back to User and adding a location back to my user but none of those make any markers reappear on any of the maps.

[OsaIsacson]

Has anyone implemented a view where you see the map on top and the list items underneath?

My client want this, but I’m advising against it. It seems to me like it would be cake on cake both ux and codewise since they both perform the same functions.

Opinions or tips on this?

[merefield (Robert)]

@OsaIsacson

the map on top

What map?

Are you referring to the Locations Plugin?

[OsaIsacson]

Apologies, yep I am. Looks like this at present on my site.

In an ideal world selecting tags on top would limit both the map and a list under the map to the selected tag.
Quickmock:

Perhaps one could:

1. Check if we are on the ‘Project and Gemenskaper’ page (easy)
2. Inject a duplicate list under the map (no clue how)
3. Hide the duplicate category/tags bar (easy)

…question is if that would make the tags work as expected (filtering both map and list on click and showing both) or if selecting one would make it default to only the list view - as it currently does when selecting a tag on the list.

Just spitballing. I don’t have a lot of hope.

[merefield (Robert)]

If you’d like to create such a view, PR accepted (so long as all else remains equal and this is just additional behaviour behind a setting).

If you need help to produce such a view on a commercial footing, you are welcome to reach out to me @ Pavilion (Locations is a Pavilion product).

[JammyDodger]

@OsaIsacson

Apologies, yep I am. Looks like this at present on my site.

As it’s a feature request for this plugin I’ve moved it over to the relevant topic.

[PeakProsperity (Aaron McKeon)]

I’ve noticed my locations plugin has stopped geocoding even though my settings have remained unchanged and my API keys from LocationIQ are still valid. The issue happens when trying to assign a location to a topic. Whenever populating the fields, the map simply spins and spins and never completes.

Is this a known issue and do you have any thoughts on how to fix it? Thanks.

– Aaron

[merefield (Robert)]

Anything suspicious in the browser console or in rails logs?

[PeakProsperity (Aaron McKeon)]

I don’t have access to the rails logs (need to ask the host), but nothing pops up when I click “Find Location”. It’s also worth mentioning I’m still on Discourse version 3.0.3.

[packman (Chris McMahon)]

Not sure if these need reporting, but I’m seeing quite a few deprecation notices for the Locations plugin, i.e.

Deprecation notice: add_to_serializer's respect_plugin_enabled argument should be passed as a keyword argument 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:87:in `block in activate!`

Deprecation notice: add_to_serializer should not be used to directly override include_*? methods. Use the include_condition keyword argument instead 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:88:in `block in activate!`

Deprecation notice: add_to_serializer's respect_plugin_enabled argument should be passed as a keyword argument 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:91:in `block in activate!`

Deprecation notice: add_to_serializer should not be used to directly override include_*? methods. Use the include_condition keyword argument instead 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:92:in `block in activate!`

Deprecation notice: add_to_serializer's respect_plugin_enabled argument should be passed as a keyword argument 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:96:in `block in activate!`

Deprecation notice: add_to_serializer's respect_plugin_enabled argument should be passed as a keyword argument 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:97:in `block in activate!`

Deprecation notice: add_to_serializer should not be used to directly override include_*? methods. Use the include_condition keyword argument instead 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:98:in `block in activate!`

Deprecation notice: add_to_serializer's respect_plugin_enabled argument should be passed as a keyword argument 
At /var/www/discourse/plugins/discourse-locations/plugin.rb:223:in `block in activate!`

I’m running the latest Discourse and plugin versions.

[packman (Chris McMahon)]

I don’t know when this happened but my User Map has no user markers on it. I know there are over 20 users with a geo_location set.

I’ve removed my own location and successfully re-added it so I don’t think geocoding is the problem. I’ve tried changing various settings but haven’t found anything that makes the users display again.

The topic location map has markers on it for the few topics that have locations set so it’s just users that are affected. I’m on the latest Discourse and Locations plugin.

Any thoughts on how to get my user markers back?

[Stephane_Roy]

Hello

Following an update yesterday of the latest version of the Location and Events plugins (and at the same time Discourse).

I encounter blocking bugs on the location and Events plugins

Map :
https://forums.ffjdr.org/map
or
https://forums.ffjdr.org/c/e-irl/14/l/map

Calendar :
https://forums.ffjdr.org/upcoming-events
or
https://forums.ffjdr.org/c/e-irl/14/l/calendar

Agenda is OK :
https://forums.ffjdr.org/agenda
or
https://forums.ffjdr.org/c/e-irl/l/agenda

Thank you for your help (and for these great plugins!)

[merefield (Robert)]

Hey everyone, the Locations Plugin is now broken due to required upstream changes to facilitate the big ongoing Ember upgrade which is way more significant that usual.

CDCK were very good at giving us a heads up but we currently are working through the required changes and will get Locations back up as soon as we can.

We recommend you DO NOT rebuild for the time being if you wish to continue using the plugin.

Sorry to those of you who have already done so.

We will resolve it when we can.

Thanks very much for your interest in this free offering.

[Richie (Richie Rich)]

@merefield

Thanks very much for your interest in this free offering.

And thank you for the continued time and support that you dedicate to this free offering

[packman (Chris McMahon)]

@merefield

We recommend you DO NOT rebuild for the time being if you wish to continue using the plugin.

Just not rebuild? So we’re safe to do upgrades from the Web Admin page?

[merefield (Robert)]

Neither, I’m afraid.

Just pretend you are on stable

[merefield (Robert)]

I’ve just merged many early mornings and late nights of work to get this show back on the road.

It is very different in implementation from the old plugin so please bear with there are probably lots of issues, I’ve barely tested it in Production:

• As part of the changes I’ve deprecated the use of widgets in favour of Glimmer implementation (widgets will eventually be on their way out). This was quite a journey, I can tell you, as the original widget code is very esoteric indeed. This should set us in good stead for a good while.
• There’s a new search system which is a little OTT (be good to add group capability at some point? if someone wants to sponsor that get in touch! )
• It no longer supports Layouts, but Layouts is currently so that’s moot - I’ll look to add back Layouts support when Layouts returns from the
• I’ve cut some corners to get here so quickly - I’ve not added any additional FE tests … may get time to add ones for the maps over time.

COMPATIBILITY: Migrate Maps to Glimmer

NB I’ve added a compatibility file so Stable should still use the old code whilst we iron out the bugs in this new approach over time …

Known Issues:

• expand doesn’t work nicely atm.
• Name search on the User map has issues.
• Layouts is not yet supported (but that’s currently )

[Stephane_Roy]

Hello

Il have just update and …the map live

Conventions JdR

Merci beaucoup

[merefield (Robert)]

that’s great @Stephane_Roy … but I think also screaming out for a dark mode?

I haven’t had time to look at that yet as an auto integration into the plugin, but there was this CSS I shared a while back you can add as a Theme Component:

:root {
  --map-tiles-filter: brightness(0.6) invert(1) contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7);
}

.locations-map {
  .leaflet-tile-pane  {
    filter:var(--map-tiles-filter, none);
  }
  .leaflet-marker-shadow {
    display: none;
  }
}

that I believe still works …

might be a little easier on the eyes?

[Roi]

@merefield

I haven’t had time to look at that yet as an auto integration into the plugin, but there was this CSS I shared a while back you can add as a Theme Component:

Still works (“normal” and dark): https://www.sidemount-forum.com/u/user-map

Btw, I just upgraded and also the plugin works again (but I skipped the non-working time period ).