Logging sometimes reports wrong database in multisite

Contribuer Fonctionnalité
1

I was investigating an issue and it seems like the lines in production.log sometimes report the wrong database.

I’ve seen this a few times before, so this is not a single incident. Here’s a good and clear example where you can see that the third line has been logged as belonging to database db3785 where it obviously is about the same request as the fourth line, which is logged as belonging to db9210.

image
image.png1008×67 4 KB

I was unable to pinpoint the responsible code, it might be deep inside Rails, and this is probably a race condition.

v1.8.x on Unicorn.

No, we’re not using Docker, no, I don’t think that matters here, and no, I don’t expect a quick solution.
Just letting you guys know what we are seeing :slight_smile:

1 « J'aime »
2

Rails logs are a trashfire, we plan to start using a new format in future

6 « J'aime »
6

I’ll put this on my list first, it seems like the connection is switched even before logging is complete.

6 « J'aime »
7

This is really unsolvable with the current log format. @tgxworld is going to investigate making GitHub - roidrage/lograge: An attempt to tame Rails' default policy to log everything. an optional (and hopefully default) log format for rails to avoid this mess and give us properly parsable log files.

3 « J'aime »
8

Note that lograge can now be enabled via a hidden SiteSetting.logging_provider or setting ENABLE_LOGRAGE to 1. We’ll be testing this on our servers for awhile before deciding if lograge should be the default for all Discourse users.

4 « J'aime »
9

Is lograge the default now?

1 « J'aime »
10

Nope but we can make it so.

3 « J'aime »
11

I am moving this to feature as we already have a system that works nicely for multisite and multisite is very very uncommon.

I am fine to move to lograge by default longer term it will give Discourse Doctor more ammo.

3 « J'aime »
12

lograge seems like a vast improvement and it took me forever to find this topic to find how to start it.

Is it too soon to un-hide the site setting?

Would it be disastrous to change the default to lograge for new installs?

It’s not immediately clear what discourse-doctor might do, grep for “Error”, but having some logs around to look at is a first step. . .

13

Yeah @tgxworld let’s make lograge the default?

14

Bonjour,

Dans notre organisation, nous utilisons lograge/Graylog pour toutes nos applications et nous employons le formatage JSON car il nous offre une méthode plus structurée pour identifier les problèmes.

Nous mettons en place un forum avec Discourse, qui propose une option lograge mais utilise le formatage KeyValue, ce qui compliquerait notre configuration.

J’ai créé une PR adding a lograge formatter env var by dscataglini · Pull Request #12206 · discourse/discourse · GitHub qui conserve le formatage par défaut sur KeyValue comme actuellement, mais permet de le remplacer en spécifiant la variable d’environnement LOGRAGE_FORMATTER.

1 « J'aime »