'max tags per topic' failing silently

Since this week. we no longer see an error message when you more than max tags per topic on a topic. Instead, the topic just saves, but the additional tags are discarded silently.

2 个赞

Hi,

it should be fixed by

https://github.com/discourse/discourse/pull/9018

I added few tests, hopefully we don’t regress on this anymore.

Thanks.

8 个赞

merged

当我想要报告 max_tags_per_topic 在当前 tests-passed 中设置为 0 时会静默失败时,我发现了这个主题。

重现步骤:

  • max_tags_per_topic 设置为 0
  • 向主题添加标签
  • 发现它没有被添加

当 max_tags_per_topic 设置为 1 时,您尝试添加第二个标签,会收到“您只能选择 1 个项目”的错误消息。

我怀疑错误在这里:https://github.com/discourse/discourse/commit/6bee972a5cebf9dccdf969f2936351cb23c641c6#diff-332f59f52705c2ca37ec4509fee6162024b4f97b8451c5c321de30d05661d127R87,如果 maximum 为 0,则 if 表达式为 false。

3 个赞

谢谢!我们已在此处修复:

1 个赞

此主题已在 19 小时后自动关闭。不再允许回复。