Message Bus - Last Seen

Roragok · December 28, 2021, 7:13pm

Hey everyone, haven’t been messing around with discourse in quite a while. I recently updated my site without testing locally. 2.8.0.beta8 - > 2.8.0.beta10

I encountered an issue with Message Bus as it now does not push notifications for users who have not been seen > 30 days.

github.com

discourse/discourse/blob/312c4173664734b803c7332015de6ceb6f5d5e62/spec/services/post_alerter_spec.rb#L1008

    
      
                  username: "username"
                )
              end
            end
          
          
  expect(events.size).to eq(0)
            expect(messages.size).to eq(0)
            expect(Jobs::PushNotification.jobs.size).to eq(0)
          end
          
          
it "does not publish to MessageBus /notification-alert if the user has not been seen for > 30 days, but still sends a push notification" do
            evil_trout.update_columns(last_seen_at: 31.days.ago)
          
          
  SiteSetting.allowed_user_api_push_urls = "https://site2.com/push"
            UserApiKey.create!(user_id: evil_trout.id,
                               client_id: "xxx#1",
                               application_name: "iPhone1",
                               scopes: ['notifications'].map { |name| UserApiKeyScope.new(name: name) },
                               push_url: "https://site2.com/push")
          
          
  events = nil

My inactive user in this instance is a bot that uses an API key. The bot posts and reads messages from the bus but it does not flag him as logging in or being seen in this case.

Is there a way I can set my bot up to ignore this? I impersonated the bot and it started reading/posting again. But i would like to avoid doing that every 30 days. Can it ignore moderators or admins for this? Also sorry if this is the wrong section.

Falco · December 28, 2021, 7:18pm

Maybe you can use our Notification WebHooks for this use case?

Roragok · December 28, 2021, 7:22pm

Possibly I’m not the best with all this. My specific use case is implemented a hubot using

My bot helps run Mafia games, responds to users votes and commands and stores the data in AWS. I’d hate to completely rework this.

bot for reference.

Falco · December 28, 2021, 7:38pm

Oh I see. You are using @featheredtoast hubot adapter. What do you think @featheredtoast ?

Roragok · December 28, 2021, 8:00pm

Hah what a small world it truly is

featheredtoast · December 28, 2021, 8:38pm

Probably the easiest thing to do here is add a “keepalive” ping once in a while so Discourse sees that the bot is actually active. I’ll see what I can do.

Topic		Replies	Views
Discourse offers to enable live notifications on macOS Safari 16, but they don't work Bug push-notifications	10	956	February 18, 2023
Message-bus is duplicating headers in Discourse chat Dev chat , rest-api	6	341	February 13, 2024
DiscourseHub failing to check for notifications and is displaying read ones Bug discourse-hub , ios-app	5	529	December 20, 2022
Push Notifications on iOS Support	10	2889	February 19, 2020
Push notifications settings Support chat	8	2327	January 19, 2023

Message Bus - Last Seen

Related topics