Missing Translate in review page

Lhc_fl · April 22, 2023, 3:04pm

It comes up on the review screen and I don’t even know what the original text is.

Version: latest discourse test-passed.

JammyDodger · April 22, 2023, 3:22pm

Yes, I’m not sure where that came from. It’s a delete button of some sort.

Hopefully we can get that fixed up soon.

Lhc_fl · April 25, 2023, 10:59am

This bug has been fixed by the team, thank you!

JammyDodger · April 25, 2023, 11:42am

Just to be thorough, it was fixed in:

github.com/discourse/discourse

FIX: Don't display destroy reviewable button on client

discourse:main ← discourse:scope-reviewable-guardian-for-api-request

opened 06:49PM - 24 Apr 23 UTC

janzenisaac

+63 -3

# Context https://meta.discourse.org/t/missing-translate-in-review-page/26260…4 ![image](https://user-images.githubusercontent.com/50783505/234089049-72332040-e7d5-4081-824a-b0b36e37187a.png) An additional button was added as a result of https://github.com/discourse/discourse/commit/dd495a0e194928fb2a11a14ff9b3403f61df1259 which was intended to grant access to deleting reviewable from the API. We were being too flexible by only checking if the user was an admin https://github.com/discourse/discourse/blob/012aaf0ba32890a93f913b469681792341198ecc/lib/guardian.rb#L237 where it should instead by scoped to check if the request was an API call. # Fix https://github.com/discourse/discourse/pull/21226/files#diff-0a2548be4b18bd4ef2dffb3ef8e44984d2fef7f037b53e98f67abea52ef75aa2R237 # Additions Added a new guard of `is_api?` https://github.com/discourse/discourse/pull/21226/files#diff-0a2548be4b18bd4ef2dffb3ef8e44984d2fef7f037b53e98f67abea52ef75aa2R657-R660 In `app/models/reviewable.rb` we check if the user has the permissions to the destroy action via the `Guardian`. To do this we were instantiating a new `Guardian` class which then caused us to lose the context of the request. The request is a necessary component in the guard of `is_api?` so we needed to pass the already defined Guardian from the `app/controllers/reviewables_controller.rb` to the `#perform` method to ensure the request is present.

JammyDodger · April 26, 2023, 7:00am

This topic was automatically closed after 19 hours. New replies are no longer allowed.