Multiple users liking a single post notification

[esmon (Simon Fugere)]

Did some poking around in the code for notifications and noticed that this condition is never met in widgets⁩/notification-item.js.es6. Running 2.3.8.

Doing a console.log of data object shows that data.count is usually undefined unless it’s a consolidated notification that one user likes more than one of your posts. Also username2 is not defined in the data object.

Is this notification type being phased out?

[codinghorror (Jeff Atwood)]

Is this dead code @eviltrout?

[sam (Sam Saffron)]

I think this stuff happens if you have notify on every like enabled. (I use this on meta)

[eviltrout (Robin Ward)]

We are definitely sending out username2 in some circumstances:

https://github.com/discourse/discourse/blob/master/app/services/post_action_notifier.rb#L31

[esmon (Simon Fugere)]

Thanks for responding @codinghorror @eviltrout. I realized this seems to have been refactored and is different in 2.4.2 now.

[codinghorror (Jeff Atwood)]

Moving this to dev discussion.