Muting topics does not stick

We’re running 2.4.0.beta11 (cf0c6d5761). Topic muting is completely broken for us.

When I mute a topic in a category that is not muted:

It appears to work:
ScreenShot 2020-02-21 at 2.40.41 PM

But then when I refresh the page with F5, the mute is gone, and it still shows up in the Latest view.

ScreenShot 2020-02-21 at 2.40.47 PM

Is this a known bug? We haven’t changed our configuration recently, although we do update fairly regularly and are on the very latest version as of today.

5 « J'aime »

Yes I can repro. It’s very unexpected. It seems to happen only on muted from the timeline, muted from under a topic seems to work, and other actions work. It’s the same component. Digging, will probably have a fix shortly.

6 « J'aime »

Fantastic! Thanks Joffrey as always.

1 « J'aime »

Ok, fixed, good catch, thanks!

https://github.com/discourse/discourse/pull/9021

This should fix it and add more tests to prevent future regression on this topic timeline button.

Waiting for tests and will merge it.

11 « J'aime »

Thanks, appreciate if you could give a heads-up when it’s merged so we can update, had a bunch of users complaining about this.

4 « J'aime »

This is merged and in tests-passed.

Let me know how it goes for you, I’m online few more hours and can fix more if needed.

5 « J'aime »

Confirmed fixed. Thanks again!

6 « J'aime »

Great thx for update

6 « J'aime »