- Click a bookmarked item
- Then hit back
- It doesn’t navigate back to where you were in bookmarks, it goes back to the previous bookmarked post/pm/etc that you visited instead.
5 Likes
I can repro this here on Meta.
2 Likes
When you say “click a bookmarked item”, where are you? Can you show a screenshot?
3 Likes
I’m on the bookmarks page: https://meta.discourse.org/my/activity/bookmarks.
Steps I took:
- Open user menu
- Click bookmark icon twice (to navigate to full bookmark activity page)
- Click a topic
- Click back
If I was to do that right now, when clicking back I’d end up here, in this topic, rather than landing on the bookmark activity page as I’d expect.
4 Likes
Click that bookmark, then hit back…you’ll wind up at whatever previous topic/post/pm you visited prior to clicking the “bookmarked item”.
5 Likes
Confirmed, yeah something is not right with our Ember routing here @martin can repro in safe mode.
Can you have a quick look? If it becomes a bit too much of a rabbit hole ping @eviltrout or @joffreyjaffeux for a hand.
3 Likes
It was fairly straightforward, I have a fix up for review now:
https://github.com/discourse/discourse/pull/12936
The topic-link component (which isn’t used in many places, the bookmark list is one of three) was just missing data-auto-route on the link generated.
7 Likes