Need to make customizable the GitHub onebox number of lines limitation instead of the current 20

dmitry_fedyuk · 10. April 2016 um 05:21

For example, the following method contains 22 lines of code, and it is impossible to publish it in a useful way.
It is only possible to publish it as…

chopped:

github.com/magento/magento2

app/code/Magento/Security/Model/ResourceModel/AdminSessionInfo/Collection.php

052e789


      
          /**
           * Update active sessions status except a specific one
           *
           * @param int $status
           * @param int $userId
           * @param string $sessionIdToExclude
           * @param int $updateOlderThen
           * @return int The number of affected rows.
           */
          public function updateActiveSessionsStatus(
              $status,
              $userId,
              $sessionIdToExclude,
              $updateOlderThen = null
          ) {
              return $this->getResource()->updateStatusByUserId(
                  $status,
                  $userId,
                  [\Magento\Security\Model\AdminSessionInfo::LOGGED_IN],
                  [$sessionIdToExclude],

This file has been truncated. show original

or splitted:

github.com/magento/magento2

app/code/Magento/Security/Model/ResourceModel/AdminSessionInfo/Collection.php

052e789


      
          /**
           * Update active sessions status except a specific one
           *
           * @param int $status
           * @param int $userId
           * @param string $sessionIdToExclude
           * @param int $updateOlderThen
           * @return int The number of affected rows.
           */
          public function updateActiveSessionsStatus(
              $status,
              $userId,
              $sessionIdToExclude,
              $updateOlderThen = null
          ) {

github.com/magento/magento2

app/code/Magento/Security/Model/ResourceModel/AdminSessionInfo/Collection.php

052e789


      
              return $this->getResource()->updateStatusByUserId(
                  $status,
                  $userId,
                  [\Magento\Security\Model\AdminSessionInfo::LOGGED_IN],
                  [$sessionIdToExclude],
                  $updateOlderThen
              );
          }

It would be nice to let the forum’s administrator to decide what should be the number of lines limitation instead of the currently 20.

riking · 10. April 2016 um 08:24

Meh, if you need to share that much code copy it into a backtick-fenced block and link to the source on the next line (with a onebox breaker, such as “Source: link”).

dmitry_fedyuk · 6. Oktober 2016 um 16:07

I have implemented it as a plugin: GitHub - discourse-pro/df-github-blob-onebox: The plugin removes the limitation on the maximum number of lines of code of the default GitHub blob onebox for the Discourse forum software
A usage example: How does \Magento\Sales\Model\Order\CustomerManagement::create() work? - Magento 2

Thema		Antworten	Aufrufe
Line context for GitHub links in onebox Support	5	624	2. Juli 2020
Github boxes should be truncated Feature	7	1573	27. Januar 2015
Option to not truncate GitHub/GitLab onebox Feature	5	727	3. September 2018
Pastebin onebox escapes page width Bug	3	1286	22. Februar 2016
Feature the related anchor in github URLs with only one line? Feature	8	1792	4. Dezember 2025

Need to make customizable the GitHub onebox number of lines limitation instead of the current 20

Verwandte Themen