No group popup without viewing members permission

AI-generated summary

In a Discourse instance running 2.5.0.beta3 and later 2.5.0.beta4, users without permission to view group members were unable to trigger any popup or navigate to the group page when clicking a group mention (e.g., @name). thomas_xr reported this as a bug, suggesting the popup should still offer available actions (like joining or messaging) even if member listing is restricted — or at minimum, allow clicking to open the group page. codinghorror agreed it’s a bug and tagged sam, who assigned vinothkannans to investigate. The issue was subsequently fixed in commit 058bf56, ensuring group mentions behave appropriately based on user permissions.

When a post mentions a group ( @name ), users viewing that post will get a popup when clicking that mention with buttons to join the group or send a message to it (if they have permission to do so).

But if the user doesn’t have permission to view the members of the group (which are shown in the bottom left of the popup) clicking on the mention does nothing, no popup, not opening the https://discourse/g/name page.

It would be great if the popup would give which ever functionality is allowed for the viewing user (joining the group / messenging the group) even if the user is not allowed to list the group members.

Otherwise if that’s not possible maybe allow clicking the link to open the group page at https://discourse/g/name

The Discourse instance on which I observed this problem was on 2.5.0.beta3 before, which I upgraded to 2.5.0.beta4 but the problem persists.

2 likes

This feels like a bug @sam, can we assign it?

2 likes

@vinothkannans can you investigate this issue?

1 like

This is now fixed in the below commit

https://github.com/discourse/discourse/commit/058bf56b4cffe962af5dcb56b82926e62e15fb32

5 likes

This topic was automatically closed after 42 hours. New replies are no longer allowed.