No Highlighting of Group mentions in Markdown Preview

AI-generated summary

The discussion revolves around the highlighting of group mentions in Markdown Preview. rriemann initially reports that group mentions do not have a distinct style applied, unlike usernames, and suggests applying a consistent style. codinghorror points out that this is not a bug, but rriemann argues that it is an issue and should be re-categorized as a bug.

sam wonders if group mentions are allowed and if the issue is related to dashes in the group name. cpradio mentions a related GitHub commit that fixed an issue with group names containing dashes.

After further testing, rriemann confirms that the issue persists, even after updating to the latest version. techAPJ eventually identifies the root cause: mixed-case group names were not being highlighted. The issue has been fixed via a GitHub commit, and techAPJ thanks rriemann for reporting the issue.

I just noticed that while usernames have a different style applied in the markdown preview (bold, gray), this is not the case for group mentions. Is this intentional? I consider this as incoherent and suggest to apply either the same style to group mentions in the preview or a different one.

Advantage: Text author is assured that mention is well recognised and functional.

Please refer to the category description of bug. This is not a bug.

I agree. I thought first this would be only the case for groups with a minus in the name @blub-blub and forgot to change the category later on.

I am really not following

2 Me gusta

I updated yesterday.

Once posted, the bold-gray style is applied.

Does the group allow mentions? what if you call it @beta is it something to do with the dash?

2 Me gusta

I wonder if this fix needed to be applied at a second location too for dealing with the composer preview?
https://github.com/discourse/discourse/commit/833af461ab5d9e170306172b68541bd62b09201a

It stemmed from
https://meta.discourse.org/t/group-mentions-that-begin-with-the-same-characters-may-be-incorrect/39892

Which had an issue with group names with dahses in them.

5 Me gusta

Looks like this may have gone unfixed?

3 Me gusta

In the preview my group @ORGANISATION-Board is still not highlighted accordingly.

I just updated to the most recent version and the highlighting does not work. :frowning:

While mentioning team here seems to work and it gets a mention-group and notify class attributed, it only gets a mention-tested class in my Discourse instance.

I suggest to put this topic back to the bug category.

Group names without a dash are not working either for me. So I kindly ask to test group name mentions with and without dashes at other Discourse instances.

2 Me gusta

Sure @techapj can you add this to your list to test maybe next week, can we repro with dashes in the group name?

2 Me gusta

This was a legit issue. The issue was: group with name discourse was getting highlighted but group with name Discourse was not getting highlighted, i.e. mixed case group names were not getting highlighted.

Fixed via:

https://github.com/discourse/discourse/commit/f387dfe2263ef198701d8876977881ce99fe385c

Thanks for reporting this issue @rriemann :thumbsup:

5 Me gusta