Nicht-Mitarbeiter können auf „Uncategorized" zugreifen, auch wenn es deaktiviert ist

[jomaxro (Joshua Rosenfeld)]

While researching https://meta.discourse.org/t/cant-prevent-creation-of-uncategorized-topics/104874/7, I found that users can view Uncategorized even if it is disabled via site setting and has no topics within it. Users can visit it by navigating directly /c/uncategorized, as well as by searching in the category filter dropdown:

The New Topic button is on the (empty) page, and lets them start composing without selecting a category, which shouldn’t be possible with the setting off. The composer should look like this:

[codinghorror (Jeff Atwood)]

Maybe we regressed here @j.jaffeux? Not sure.

[j.jaffeux (Joffrey Jaffeux)]

I don’t think we regressed here.

• the URL is not a problem for me, I think we can leave it, it’s not causing any arm
• I can fix the category drop simply with FIX: do not show #uncategorized in category drop if setting is disabled by jjaffeux · Pull Request #6856 · discourse/discourse · GitHub

[jomaxro (Joshua Rosenfeld)]

@j.jaffeux

the URL is not a problem for me, I think we can leave it, it’s not causing any arm

Fine with me.

@jomaxro

The New Topic button is on the (empty) page, and lets them start composing without selecting a category, which shouldn’t be possible with the setting off.

What about this? It seems like a regression to me - with Uncategorized disabled users should be required to select a category before composing the body. However they are able to compose the body without a category if they click new topic from the uncategorized page.

[j.jaffeux (Joffrey Jaffeux)]

Yes I fixed what was very easy for me. Need to think about the composer, if you thought we absolutely had to remove the URL, then it was solved with it. Maybe I should just redirect. Need to dig more, uncategorized has many cases and I’m unsure what this would cause.

[codinghorror (Jeff Atwood)]

What did we want to do with this @j.jaffeux?

[sat]

I can confirm this bug is still there. You will not see uncategorized category in search but if you access thru link it shows.

https://yourdiscoursesite.com/c/uncategorized

[sat]

@codinghorror anyone looking into this?

[codinghorror (Jeff Atwood)]

@sat

You will not see uncategorized category in search but if you access thru link it shows.

That’s… not a bug though. The OP stuff, @j.jaffeux I am sure is looking at.

[sat]

I feel it is a bug.
If I access “staff” or “lounge” category it shows “Oops! That page doesn’t exist or is private.”

but for “uncategorized” it shows “There are no more Uncategorized topics.” I deleted all topics otherwise it shows those topics.

[Stephen]

Sure because those are private categories.

It’s not a bug, nor is it the subject of this topic.

[schleifer (Andrew Schleifer)]

For the purposes of the bug category, there is a specific definition:

@sam

A bug report means something is broken, preventing normal/typical use of Discourse

That is unexpected behaviour, but it is not a bug.

[j.jaffeux (Joffrey Jaffeux)]

@jomaxro

Der Button „Neues Thema“ befindet sich auf der (leeren) Seite und ermöglicht es Nutzern, eine Zusammenstellung zu beginnen, ohne eine Kategorie auszuwählen. Das sollte bei deaktivierter Einstellung nicht möglich sein. Der Editor sollte so aussehen:

Ich denke, das wäre eine angemessene Lösung:

FIX: removes uncategorized context if not allowed in composer (#7922)

Ich habe keinen Test geschrieben, da es im JS-Test-Suite derzeit nichts zu geben scheint, das mit „ohne Kategorie“ zusammenhängt.

[codinghorror (Jeff Atwood)]

Schließe dies @jomaxro, wenn du der Meinung bist, dass es jetzt in Ordnung ist.