AquaL1te reported an issue where not all installed theme components are listed as installed in Discourse. Despite installing multiple components, only the “hamburger theme selector” is registered as installed. awesomerobot identified the problem as Discourse checking for the theme’s name to determine if it’s installed, which can fail if the name changes. The solution is to check against the repo URL instead. According to Osama, this issue is fixed in a commit on GitHub.
Below are 2 screenshots. The first one lists the theme components I installed. The next screenshots shows the overview of what Discourse registers as installed. Only the hamburger theme selector is listed as installed. When I e.g. install the GIF plugin again, it duplicates it in the list.
I already did a ./launcher rebuild app, but that didn’t change anything. What else can I try to update this listing? I’m afraid that automatic updates are not working properly because of this.
Hmm yes I can see this problem too, it looks like we’re checking for the theme’s name to determine if it’s installed… so if its name changes (either locally or remotely before it’s installed) it won’t be recognized as installed.
We should probably check against the repo URL instead, that should change less often than the name… the good news is that this won’t impact any kind of automatic updates.
This is fixed in:
https://github.com/discourse/discourse/commit/a6850d96914f40eed4c7c3035caace198506e724
Thanks for reporting @AquaL1te!
This topic was automatically closed after 2 days. New replies are no longer allowed.
