Onebox Twitter embedding

Oh, thanks! Is it possible to do that without actually allowing Twitter logins?

Disable enable twitter logins and just provide twitter consumer key & twitter consumer secret.

3 Me gusta

Tried it. It didn’t work. Embedded tweets still do not contain images.

Some long tweets with images don’t work

Shorter tweets with images works

It exists since the new twitter policy regarding links and images in the 140 characters count

6 Me gusta

I’ve just submitted a PR which should fix this:

10 Me gusta

@david - thank you! We do a lot of Twitter oneboxing and found the truncation very annoying.

4 Me gusta

This is terrific - my forum users really need this.

Is this merged into a future release or something we have to do to modify in our existing installations?

Just upgrade on latest version, it should be good :

  • via yourforum.com/admin/upgrade
  • or SSH into your server and do these commands :

cd /var/discourse
git pull
./launcher rebuild app

I don’t think you need to add the twitter consumer key and twitter consumer secret in your admin settings but I’m only 99% sure

2 Me gusta

Yep - it’s all merged into master and working great on my forum

I’m afraid you will need to add these keys to your site settings - the data is fetched via the twitter API rather than opengraph/oembed.

2 Me gusta

It’s always the 1% left

1 me gusta

I just pushed a small improvement for Twitter onebox. The onebox will now show like and retweet count.

11 Me gusta

Twitter onebox with videos are really long on mobile. Here’s one I am adding to this post.

How it appears on mobile:

5 Me gusta

@awesomerobot is there a simple CSS fix for :arrow_double_up:

4 Me gusta

At the moment on mobile we set a max-height (70vh) and 100% width, and the video scales to fit. This works better for portrait oriented videos than landscape.

We can assume most videos will be landscape, but then we crop portrait oriented videos pretty severely as a trade-off.

There’s no simple fix for both without knowing the aspect ratio (Are we able to calculate the aspect ratio of these and maybe append a style based on that? the iframe seems to come with height/width).

4 Me gusta

Yes, we can do that. This is the line where we build the iframe

What HTML structure would be most useful for you @awesomerobot? Something like

<div class='tweet-images'>
  <div class='aspect-image-full-size' style='--aspect-ratio:#{width}/#{height};'/>
    <iframe class='tweet-video' src='https://twitter.com/i/videos/blah' width='123' height='456' frameborder='0' allowfullscreen></iframe>
  </div>
</div>

And then we can re-use the aspect-image-full-size logic which we use for images?

1 me gusta

Yeah I think that could work, with the aspect ratio there I should be able to adjust as needed.

2 Me gusta

I’m trying to figure out how to make tweets pulled from zapier into a topic to appear like this and I’m having trouble. Anybody able to point me in the right direction? Should it work if I just enable “onebox” in settings?

3 Me gusta

¿Hay alguna manera de que los tweets incrustados muestren el tweet al que se responde? Por ejemplo, si incrusto este tweet https://twitter.com/AOC/status/1230329539924025345, en phpBB y vBulletin se muestran tanto el tweet como la respuesta a la que ella responde.
phpBB:

vB:

Pero en Discourse solo se muestra la respuesta, lo cual a menudo no tiene sentido sin el contexto del tweet original

Por supuesto, es bastante sencillo publicar tanto el tweet original como la respuesta, pero la mayoría de los usuarios (y algunos bots de Twitter que utilizamos) no son lo suficientemente inteligentes o conscientes para darse cuenta de que necesitan hacer esto.

7 Me gusta

Este es un problema muy muy complicado: el código de inserción “oficial” de Twitter tiene dos problemas:

  1. No nos proporciona la altura, por lo que los temas se moverían mientras se carga.
  2. Tendríamos que ejecutar los archivos de JavaScript de Twitter en todos nuestros sitios.

Hemos solucionado esto utilizando nuestro propio renderizador personalizado, pero desafortunadamente eso significa que seguimos necesitando ponernos al día con el código de inserción oficial.

6 Me gusta