Onebox v1.8.41 is broken :( PR ready :)

bug
1

v1.8.41 released yesterday was sadly broken (travis, rake, )

https://github.com/discourse/onebox/pull/381 has one version of a fix

2 Likes
2

PS – workaround (if needed in meantime) is to:

  • either avoid v1.8.41,

    gem 'onebox', '~> 1.8.13', '!=1.8.41'

  • or just include fast_blank in your Gemfile.

    gem 'onebox', '~> 1.8.13'
gem 'fast_blank'

(maybe you are already implicitly or explicitly depending on fast_blank, in which case you don’t need to do anything.

4

OK this is fixed per:

https://github.com/discourse/onebox/commit/5257b8e9e9d5271456cba71643dd907559992b9d

I went with the Active Support implementation here, this does not need to be finely tuned really. strip.empty? is not exactly the same cause there are missing unicode blanks there.

4 Likes
5

This topic was automatically closed after 29 hours. New replies are no longer allowed.