Oneboxing large images fails with no visual cue

Arkshine · April 14, 2023, 7:51pm

If you upload the image, it will be optimized before the upload happens.

Also, you can see the limit in the browser console

Let’s forget what you see here; it’s misleading with your issues.

From what I tested on your forum, posting an image link works well.
That would be welcome if you could provide another concrete example.

One thing that bothers me is why this image, for example, https://dronescene.co.uk/images/uploads/fullsize/20230227161106_DJI_0087_1.jpg is still failing on your forum (and I can’t reproduce it elsewhere)

From what I see, the cache is only 1h.

github.com

discourse/discourse/blob/main/app/controllers/onebox_controller.rb#L22


      
          
          
# only 1 outgoing preview per user
          return render(body: nil, status: 429) if Oneboxer.is_previewing?(current_user.id)
          
          
user_id = current_user.id
          category_id = params[:category_id].to_i
          topic_id = params[:topic_id].to_i
          invalidate = params[:refresh] == "true"
          url = params[:url]
          
          
return render(body: nil, status: 404) if Oneboxer.recently_failed?(url)
          
          
hijack(info: "#{url} topic_id: #{topic_id} user_id: #{user_id}") do
            Oneboxer.preview_onebox!(user_id)
          
          
  preview =
              Oneboxer.preview(
                url,
                invalidate_oneboxes: invalidate,
                user_id: user_id,
                category_id: category_id,

github.com

discourse/discourse/blob/main/app/controllers/onebox_controller.rb#L40-L44


      
          if preview.blank?
            Oneboxer.cache_failed!(url)
            render body: nil, status: 404
          else
            render plain: preview

github.com

discourse/discourse/blob/main/lib/oneboxer.rb#L294-L296


      
          def self.cache_failed!(url)
            Discourse.cache.write(onebox_failed_cache_key(url), true, expires_in: 1.hour)
          end

nbianca · April 25, 2023, 2:48pm

There are two ways images can be oneboxed and unfortunately, only one was handled correctly. This should be fixed in:

Richie · April 25, 2023, 6:34pm

Thanks for looking in to this Bianca

images can be oneboxed by the AllowlistedGenericOnebox or ImageOnebox and only AllowlistedGenericOnebox was handled correctly

Are you able to tell if this bug was a regression?

Canapin · April 26, 2023, 12:18pm

Hi Richie

Please tell us if this change fixes your issue when it’s live.

Richie · April 26, 2023, 1:32pm

I’ve looked at the code changes in the commit from Bianca, looks promising

nbianca · April 26, 2023, 7:48pm

The fix has been merged, updating should resolve the issue on your site as well.

I think this has been a bug from day 1.

Canapin · May 4, 2023, 8:37pm

The fix was merged and this is what will be displayed now when we link a remote image too large to be downloaded to Discourse when download remote images to local is set to true.

Topic		Replies	Views
Incorrect or failing oneboxes for links to other discourse instances bug	17	2006	August 17, 2017
Old image uploads become broken images support	63	8037	May 24, 2021
Fix broken images for posts created by the WP Discourse and RSS plugins admins wordpress , rss-polling , how-to	33	3774	August 20, 2021
"Onebox Assistant", crawl for those previews reliably! plugin onebox	74	9733	April 21, 2023
Instagram oneboxing feature	111	10732	November 27, 2020

Oneboxing large images fails with no visual cue

Related Topics