Problema di compatibilità PG13 🔥

ted · 18 Ottobre 2024, 4:35am

Ho un PR qui che dovrebbe funzionare anche per PG13.

github.com/discourse/discourse

FIX: Make problem check tracker unique constraint work on PG13

main ← fix/problem-check-target-pg13

opened 03:40AM - 18 Oct 24 UTC

Drenmi

+32 -11

### What is this change? In #29169 we added a `NULLS NOT DISTINCT` option to …the unique index on `problem_check_trackers`. This is to enforce uniqueness even when the `target` is `NULL`. (Postgres considers all `NULL`s to be distinct by default.) However, this only works in PG15. In PG13 it does nothing. This commit adds a default dummy string value `__NULL__` to `target`. Since it's a string, PG13 will be able to correctly identify duplicate records. ### Is it safe to run this? Adding a default value will lock the table and can cause issues on large tables, but the `problem_check_trackers` table is constrained by the number of problem check classes, and is in the ballpark of 10-100 rows.

Stiamo ancora valutando quanto sia realistico questo caso in natura e quanto dovremmo investire per aggirarlo.

Argomento		Risposte	Visualizzazioni
Restore fails - could not create unique index Installation	22	3831	Luglio 6, 2020
"EXCEPTION: psql failed: DETAIL: Key (post_id)=(36946) is duplicated." Installation	8	1187	Giugno 20, 2022
Restore fails: could not create unique index Installation	10	1212	Febbraio 13, 2022
Problem with restore Discourse from backup (3.4, quite large DB) Support	18	233	Gennaio 14, 2025
Error restoring backup "key is duplicated" Installation	8	1806	Agosto 31, 2017

Problema di compatibilità PG13 🔥

Argomenti correlati