palant
13 ביולי, 2016, 5:22pm
1
I would have expected username_as_name setting to apply to all users imported from phpBB - the importer modifies the usernames both for regular and anonymous users. However, this setting currently only applies to regular users, anonymous users always get an empty name.
Besides, wouldn’t it make sense to have “only if modified” as an option here? It would probably be best to set the original username as Discourse name only if original username and Discourse username aren’t the same.
לייק 1
gerhard
13 ביולי, 2016, 8:10pm
2
I wouldn’t call this a bug.
לייק 1
gerhard
27 ביולי, 2016, 8:36pm
3
This is now fixed:
master ← gschlager:phpbb3
merged 08:57PM - 27 Jul 16 UTC
- Ignore irrelevant query parameters in internal links (see [topic on meta](http… s://meta.discourse.org/t/phpbb3-importers-link-conversion-breaks-links-with-additional-parameters/47225))
- Don't fail if guest usernames differ only by case (see [topic on meta](https://meta.discourse.org/t/phpbb-importer-fails-to-import-anonymous-users-differing-only-by-letter-case/47083))
- Import username as name for guest users if enabled in settings (see [topic on meta](https://meta.discourse.org/t/phpbb3-importer-username-as-name-setting-doesnt-apply-to-anonymous-users/47232))
And the “only if modified” logic for names is implemented too:
master ← gschlager:import-username
merged 08:30PM - 27 Jul 16 UTC
This commit contains two changes:
- We should always store the original username… as `import_username` instead of the username that could have been changed during the import.
- Set the user's `name` to the original username if the user doesn't have a name and the username was changed during the import. This was [suggested on meta](https://meta.discourse.org/t/phpbb3-importer-username-as-name-setting-doesnt-apply-to-anonymous-users/47232).
4 לייקים
