FA locks are a bit more distinct, but my reasoning for using a different icon for private is this:
Locked category | Private category |
---|---|
Changes are locked | Key is needed for access |
FA locks are a bit more distinct, but my reasoning for using a different icon for private is this:
Locked category | Private category |
---|---|
Changes are locked | Key is needed for access |
I donāt feel qualified to make the call here, so please letās reduce the noise:
Donāt post any more icon suggestions in here unless youāre sending them as a PR which you have tested!
LOL look at you trying to turn off a bikeshed topic. Thatās adorable
Anyways, I am open to this if we can decide on a final outcome, but letās have @jordan-vidrine @awesomerobot @Johani weigh in.
As someone who often takes screenshots in an environment with lots of mixed-access content, I strongly disagree! I suspect file sharing benefits from being log-in-only and private-first when it comes to not labeling things.
Some sites could definitely remove the icon without issue, but it would be dangerous for others.
Using the same icon and relying on context to differentiate the meaning requires a bit more mental work than having two distinct iconsā¦ but itās also very possible that a distinct but less apparent icon could be more confusing.
Anyway, what weāre trying to communicate is āthis category is access-restrictedā (from the public or other groups)
The padlock with the user seems closer to the area of āsomething about security and peopleā rather than just āsomething about securityā but itās not a good icon at small sizes. Is this a shopping category?
so what about a key?
ehhā¦ similar issue, the small size and lack of association with a lock or some other related thing makes it lose meaning really quickly. Plus if a topic is lockedā¦ is the category the key to the topicās lock? whatās that association all about?
Unlocked is probably the closest usable suggestion hereā¦
I think this could potentially be as ambiguous as the lockā¦ just in the opposite way.
More importantly, there are a lot of Discourse sites in the world nowā¦ and we might give a good number of admins heart attacks if their locked icons are suddenly unlocked. Thatās enough of a concern that I donāt think itās worth remotely considering!
A lock isnāt perfect, but itās the best weāve got!
Can we test out a few different icons for āclosed topicā then?
Considered ban, but it feels a little too much like itās saying ādo not enterā to me
A slashed speech-bubble maybe? Could argue that itās more literalā¦ might be a little less clear visually (could try some adjustments to improve that).
We wouldnāt be able to use that exact icon as mocked up above though because itās under Font Awesomeās commercial licenseā¦ but it wouldnāt be difficult to create something following the same concept.
Letās change closed I like that idea better.
Hereās how a custom comment-slash would look in some different contexts, put it above the unlisted icon here just to check how similar it is:
In topic titles:
Topic status message:
I agree that the slash-through speech bubble is the right direction for a closed topic.
This looks good however, I have mixed feelings - a step forward, but it looks weirdā¦ To me it doesnāt give a āclosedā vibe. It looks more like another version of a muted icon. How does it look in the admin wrench?
Personally, I get a āno talking allowedā from this icon, which is what we want to convey here. I like it
Iāve just made the update. I also added a new ādiscourse-commentā icon so the speech bubble styles matchā¦
https://github.com/discourse/discourse/commit/b6489d269045d28ad1f8c6dc7e41f991390f002c
Actually does not look bad at all in the admin wrench
Doesnāt the make public topic icon look alike to open topic ?
I have mixed feelings about thisā¦ ironically it fights with the Discourse logo visually ā¦ probably not an issue with other logos?
Also open feels kind of generic. Maybe we need the talk bubble and a plus?
I am thinking close is good as-is, but open is the problem, hereās my mock of what I feel we should do
An interesting thing, since I am admin on so many sites, closed never meant to me āend of discussionā ā¦ it is more āwe are done with this topicā. So conceptually the lock was good and this change is ā¦ surprising.
I will live with this though for a few weeks and see how I feel, my knee jerk ā¦ why did you move my cheeseā¦ reaction here is I would have preferred changed the icon for secure categories.
But who knows how I will feel in 2 weeks.
Agree I want to live with this for a while. I think the glyph is clearer this way.