PM 'Invite Others' button disabled when local logins disabled

LeoMcA · 28 Ottobre 2015, 6:55pm

I understand that disabling invites is intended behaviour when local logins are disabled, but it seems to have the knock on effect of removing any way to add a new user to a PM:

github.com/discourse/discourse

app/assets/javascripts/discourse/templates/components/private-message-map.hbs

8a5f8d62b


      
                {{/user-link}}
                {{#user-link user=au}}
                  {{unbound au.username}}
                {{/user-link}}
                {{#if details.can_remove_allowed_users}}
                  <a href class='remove-invited' {{action "removeAllowedUser" au}}>{{fa-icon "times"}}</a>
                {{/if}}
              </div>
            {{/each}}
          </div>
          {{#if details.can_invite_to}}
            <div class='controls'>
              <button class='btn' {{action "showPrivateInvite"}}>{{i18n 'private_message_info.invite'}}</button>
            </div>
          {{/if}}

github.com/discourse/discourse

lib/guardian.rb

e29fe77b4


      
            SiteSetting.enable_local_logins &&
            (
              (!SiteSetting.must_approve_users? && @user.has_trust_level?(TrustLevel[2])) ||
              is_staff?
            ) &&
            (groups.blank? || is_admin?)
          end
          
          def can_invite_to?(object, group_ids=nil)
            return false if ! authenticated?
            return false unless ( SiteSetting.enable_local_logins && (!SiteSetting.must_approve_users? || is_staff?) )
            return true if is_admin?
            return false if (SiteSetting.max_invites_per_day.to_i == 0 && !is_staff?)
            return false if ! can_see?(object)
            return false if group_ids.present?
          
            if object.is_a?(Topic) && object.category
              if object.category.groups.any?
                return true if object.category.groups.all? { |g| can_edit_group?(g) }
              end
            end

codinghorror · 28 Ottobre 2015, 8:24pm

Maybe, @techapj can you have a look?

techAPJ · 30 Ottobre 2015, 6:30am

Fixed via:

https://github.com/discourse/discourse/commit/9f8d6b6088912295421ebd04cf865677868a45ab

Also note that now user will also be able to invite existing users to a topic when local logins are disabled.

Argomento		Risposte	Visualizzazioni
Send Invites button should not be visible if local logins are disabled Bug	4	982	Luglio 5, 2019
Invites missing Support	2	625	Giugno 8, 2024
Invites doesn’t allow use external auth with local logins Bug	2	62	Aprile 26, 2025
Scope of private message disabling Support	3	1124	Maggio 19, 2017
How to add a user on private forum when local login is disabled? Support	3	1384	Marzo 6, 2015

PM 'Invite Others' button disabled when local logins disabled

Argomenti correlati