Entrées/sorties PostgreSQL incontrôlées

[JanJoost]

Bonjour à tous,

Je rencontre un problème et j’aimerais solliciter votre aide. J’ai installé un serveur Discourse en utilisant l’installateur basé sur Docker. Chaque jour vers midi, pour une raison encore inconnue, le serveur devient lent et la charge d’E/S augmente jusqu’à ce que le forum affiche des erreurs 500.

iotop m’indique toujours qu’il s’agit d’une commande UPDATE PostgreSQL qui consomme toutes les ressources d’E/S.

Aujourd’hui, lorsque le problème s’est reproduit, j’ai récupéré la liste de toutes les requêtes SQL en cours d’exécution avec cette commande :
sudo -u postgres psql discourse -o /tmp/RunningQueries -c ‘SELECT datname,pid,state,query FROM pg_stat_activity’

La sortie de cette commande est disponible ici sur Pastebin.

Comme vous pouvez le constater, à ces moments-là, environ 32 requêtes UPDATE sont en cours d’exécution. Lorsque cela se produit, iotop indique que la base de données effectue des lectures et des écritures allant de 2,5 Mo/seconde jusqu’à 15 Mo/seconde.

Si je corrèle la requête UPDATE en cours d’exécution avec la requête journalisée (dans /var/discourse/shared/standalone/log/var-log/postgresql), je constate que ces requêtes prennent un temps très long :

2018-07-03 12:51:27.052 UTC [17504] discourse@discourse LOG:  duration: 2352061.872 ms  statement: UPDATE drafts
                       SET  data = '{"reply":"\u003credacted for debugging purposes\u003e","action":"reply","categoryId":24,"postId":118034,"archetypeId":"regular","whisper":false,"metaData":null,"composerTime":65922,"typingTime":8400}',

correspond à

  discourse | 17504 | active | UPDATE drafts                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  +
           |       |        |                SET  data = '{"reply":"\u003credacted for debugging purposes\u003e","action":"reply","categoryId":24,"postId":118034,"archetypeId":"regular","whisper":false,"metaData":null,"composerTime":65922,"typingTime":8400}',                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    +
           |       |        |                     sequence = 124,                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            +
           |       |        |                     revisions = revisions + 1                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  +
           |       |        |                WHERE id = 84548

Si je redémarre l’application Docker, les requêtes finissent par se terminer, donc pour l’instant, je n’ai d’autre choix que d’attendre, ce qui rend mes utilisateurs mécontents.

Merci de me faire savoir s’il y a quoi que ce soit que je puisse faire pour atténuer ce problème — par exemple, déplacer les tâches de maintenance vers environ 5 heures du matin.

Si vous avez d’autres suggestions pour approfondir l’analyse, n’hésitez pas à les partager ! Toute aide est la bienvenue

Ninja-edit : Je viens de me souvenir d’une information supplémentaire : je n’ai pas pu relier ce problème à des tâches cron existantes (ni du système hôte ni de l’application Docker).

Quelques informations de contexte sur le serveur :

• Système d’exploitation du serveur : Ubuntu 18.04LTS
• Machine virtuelle avec 100 Go de disque, 4 Go de RAM, 4 cœurs
• Disque : RAID10 sur 6 disques de 15K tours
• Discourse v2.1.0.beta2 +107
• Plugins : babble, whos-online, voting, cakeday, anonymous-categories, league
• Vues de pages par jour : environ 75 000
• Utilisateurs : 1350, environ 700 actifs par jour
• 73 600 publications, 351 sujets, le sujet le plus actif contient 13 500 publications

Merci d’avoir lu jusqu’ici !

[Falco]

@JanJoost

• Disk is a 6-disk RAID10 with 15K disks

• Are those spinning disks?

• How big is your database?

I had an experience like this with the combo: active forum + spinning disks. In the end it was Redis and PostgreSQL fighting for IO and after a while redis would stop because it had multiple rdb saves in the queue to happen.

Can you please check if redis is saving to disk during the problem?

[JanJoost]

They are SAS disks, 900GB 15K (spinning disks, not SSDs) configured in RAID10. They are not exactly slow, but you obviously wouldn’t get the IOPS you’d get from an SSD.

As for the database: the postgres_data directory is 4.5GB.

I doubt it’s redis in this case though - I stupidly enough forgot to grab a full screenshot from iotop but I can’t remember seeing redis in there. Did see postgres UPDATE at the top of the list with IO activity of 98% and up.

BTW: I’ll check tomorrow as I have no doubt it will happen again. And I’ll grab a screenshot from iotop.

[codinghorror (Jeff Atwood)]

@Falco

after a while redis would stop because it had multiple rdb saves in the queue to happen.

I still don’t feel redis should be constantly clobbering the disk. It’s supposed to be an in memory key-value store most of all.

[JanJoost]

@Falco

Can you please check if redis is saving to disk during the problem?

Hi, server’s very busy again - changed the timezone within the container from UTC to GMT+1 (Europe/Amsterdam) and indeed, load now starts 2 hours later.

Screenshot from iotop -o (which only lists the actual tasks doing I/O):

I’ve observed the behaviour and indeed, over the last 5 minutes, I did see Redis pop up twice, but only for a moment. Doesn’t come across as being the source of the problems to me.

I have a feeling there are some scheduled tasks which are being started, but I can’t really find the source. Checked cron jobs from both within the container and the underlying OS - no dice.

If you have any suggestions then those would be more than welcome! Also, if there’s more I can do regarding information gathering, please tell me!

[codinghorror (Jeff Atwood)]

More likely Postgres then, if you have ruled Redis out.

[JanJoost]

@codinghorror

More likely Postgres then, if you have ruled Redis out

I think so too - see the screenshot of the output of iostat - it’s a PostgreSQL UPDATE command that generates most of the IO load.

Thing is: what is triggered here? And why? Where can I find how (and when!) the postgresql maintenance tasks are triggered?

Edit: Additional info: Screenshot from sidekiq:

[Falco]

Looks like your problem is this one: Reschedule sidekiq scheduled job

You have one still active topic (last reply 19m ago) with 17k posts. That plus slow disks kill performance. The fact that your data is larger than the RAM also makes this more complicated.

[JanJoost]

@Falco

You have one still active topic (last reply 19m ago) with 17k posts.

That’s the most popular topic indeed. Would it be better to break it up in pieces, close this one and open a new one?

Thanks for the pointer btw - I’ll have a look!

[Falco]

@JanJoost

Would it be better to break it up in pieces, close this one and open a new one?

Yes. I set auto close topics post count to 1024 or 512 when I had an HDD instance.

Also, I completely forgot, but looks like I took an stab at this query 2 years ago:

Post.calculate_avg_time() taking up a long time

I believe the daily version of the query can be optimized by moving the filter up in the subquery. Before: kmV3 : Discourse Post.calculate_avg_time daily | explain.depesz.com After: i3JU : Discourse Post.calculate_avg_time daily Optimized | explain.depesz.com This would not apply to the weekly one, but as you stated the daily one is the bugger. Can you try that and confirm the differences @michaeld ?

[codinghorror (Jeff Atwood)]

Surprising that you are running into this with 17k posts in one topic, I view 20k as the “starting to be a problem” cutoff. But maybe we should set the bar lower cc @tgxworld

[JanJoost]

@codinghorror

Surprising that you are running into this with 17k posts in one topic

It could be related to my specific setup though - if it helps i can document a bit more, run some additional tests etc (bonnie++ or so).

[Falco]

@JanJoost

if it helps i can document a bit more, run some additional tests etc (bonnie++ or so).

We have some public results about disk bench here:

@codinghorror

Disk benchmarks

ioping -RD -w 10 .

12.8k iops, 50.0 MiB/sec vs 13.6k iops, 53.2 MiB/sec

(roughly the same disk performance)

Maybe run those (when the forum has low load) to compare?

[RGJ (Richard - Communiteq)]

Just as a thought exercise: what exactly would break if this specific job would not exist or run?

I can’t find any place in the code where Post.avg_time and Topic.avg_time are actually being used? Or is there maybe some generated accessor that I’m missing?

[zogstrip]

It’s used to compute the post score that we use to rank posts so we can summarize them.

[sam (Sam Saffron)]

@codinghorror

Surprising that you are running into this with 17k posts in one topic, I view 20k as the “starting to be a problem” cutoff. But maybe we should set the bar lower cc

I have mentioned this particular issue before… it is totally unrelated to @tgxworld’s work.

Reschedule sidekiq scheduled job

If we give up the requirement for a gemetric mean of read time on every post on large topics, we can make the job much faster and then its a lot less likely to kill his system at 3AM. In theory that code should work, my guess is that it is writing it to the wrong part of redis, you want to be at the default site of the multisite.

I am still not buying that we are getting any value from “geometric mean of all read times for all posts”… a simple… which posts are read most is probably good enough for the “best of” algorithm.

Plus this whole concept is a bit broken imo cause the further you get to the end of a topic the less people read it.

I think a simple fix here, is to stop doing the whole geometric mean read time thing on topics with more than say 1000 posts. Which is oddly the only time we would use it…

[JanJoost]

@sam

I think a simple fix here, is to stop doing the whole geometric mean read time thing on topics with more than say 1000 posts. Which is oddly the only time we would use it…

Silly idea perhaps: Topics have a certain flow, setup, experience to them. Some topics are by nature filled with short posts, others with long posts.

Would it be an idea to calculate the mean over the first 500 or 1000 posts and use that as an indication for all posts in the thread?

After all, it’s an indication so an approximation would be acceptable, no?

[RGJ (Richard - Communiteq)]

@JanJoost

calculate the mean over the first 500 or 1000 posts

I don’t even know if this would help in our case. Fact is that post_timings is bigger than the internal memory of the server (20 GB vs 16 GB) and even limiting to the first x posts would still result in the database failing to pull the entire table into memory.

So my feeling is that attempting to do this query differently would work better than trying to “limit” it.

[JanJoost]

@Falco

Disk benchmarks

ioping -RD -w 10 .

12.8k iops, 50.0 MiB/sec vs 13.6k iops, 53.2 MiB/sec

(roughly the same disk performance)

Maybe run those (when the forum has low load) to compare?

Hi, I did run a test just now on the server (still relatively active with 30 active users online). These are the results:

19.3 k requests completed in 9.89 s, 75.5 MiB read, 1.95 k iops, 7.63 MiB/s
generated 19.3 k requests in 10.0 s, 75.5 MiB, 1.93 k iops, 7.55 MiB/s

Everything seems to be about 1/7th of the speed you get. Perhaps indeed I should consider switching from old-school HDD to SSDs.

[codinghorror (Jeff Atwood)]

These numbers are terrifyingly bad even for traditional HDDs. Way below what fancy enterprise 10k and 15k drives should be doing.