ondrej
16 فبراير 2021، 9:38ص
1
Hello,
The issue is that if you go to /new and press ‘Dismiss New’ then the page reloads but the topics don’t disappear.
إعجابَين (2)
sam
(Sam Saffron)
16 فبراير 2021، 10:33ص
3
We have been fiddling with the implementation to add support for dismiss new on tags, assume you have a repro on meta? Can you leave as is and we will debug
3 إعجابات
ondrej
16 فبراير 2021، 10:36ص
4
Yes I can repro here. I will leave it as it is. Thanks for getting back to me.
3 إعجابات
Thank you for reporting that bug. I fixed it with this PR. Can I ask you to retest it?
master ← KrisKotlarek:improvement-for-dismiss-topic
merged 11:39PM - 17 Feb 21 UTC
The bug was mentioned on meta: https://meta.discourse.org/t/pressing-dismiss-new… -doesnt-clear-new-topics/179858
Problem is that sometimes the user has TopicUser records with `last_read_post_number` set as NULL. In that case, the topic is still "new" to them and should be dismissed when they click dismiss button.
In addition, I added that condition to post_migration and bumped the number to fix existing records. Migration is written to be idempotent so it will make no harm to already deployed instances.
إعجابَين (2)
ondrej
18 فبراير 2021، 11:01ص
6
Hi Kris it works fine now thanks!
إعجابَين (2)