Quotes pointing to deleted post gets stuck loading

ساهم ميزة
1

Go to the following post:

Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.

إعجابَين (2)
2

This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.

إعجاب واحد (1)
3

Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.

As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.

4

Can’t know that until we check on click.

5

Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.

4 إعجابات
6

This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh

I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.

Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.

4 إعجابات
7

Sure can you make that change @eviltrout? This one is long overdue.

3 إعجابات
9

I think this was done? If I try as anonymous I get a trash icon instead.

Screen Shot 2017-04-24 at 1.39.15 PM.png1278×176 7.37 KB

3 إعجابات
10

Good ol’ @neil did it!

3 إعجابات
13

يبدو أن هناك نوعًا من التراجع هنا، انظر إلى الرابط المضمن Manually update Discourse and Docker image to latest - #112 من دين، حيث يُظهر تحميلًا لا نهائيًا. لا يزال يعمل في الاقتباس البسيط الذي يحتوي على رابط لكنه لا يعمل مع موضوع/منشور مرتبط تم حذفه.

Uc4wgdh
Uc4wgdh793×343 17.2 KB

تعديل: عند النظر إلى المنشور الأصلي لهذا الموضوع، يبدو أنه لن يعمل مع رابط داخل اقتباس. يُظهر «تحميل» لأقل من ثانية واحدة لكنه لا يعرض أيقونة «سلة المهملات» التي تشير إلى أن رابط/نص المرجع قد تم حذفه. في هذه الحالة، يميل المستخدم العادي إلى النقر على الرابط في الاقتباس وينتهي به الأمر في صفحة 404.

إذًا، يعمل مع اقتباس نصي بسيط جدًا، دون روابط بداخله.

إعجابَين (2)
14

Is this fixable easily @eviltrout? Maybe take a peek Monday.

إعجاب واحد (1)
15

Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.

https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4

3 إعجابات