Rake db:migrate should LOAD_PLUGINS by default

fzngagan · October 14, 2020, 6:48am

We at Pavilion have had issues running/debugging tests and saw errors with the poll plugin while running tests. We use to think its some issue with the plugin itself but its not.

The issue was that the migrations of poll plugin hadn’t run. Running RAILS_ENV=test rake db:migrate LOAD_PLUGINS=1 fixed it.

Just wondering that the rake task should LOAD_PLUGINS as a default?

sam · October 14, 2020, 7:08am

We already do that here:

github.com

discourse/discourse/blob/master/bin/rake

#!/usr/bin/env ruby
# frozen_string_literal: true

if ENV['RAILS_ENV'] == 'test' && ENV['LOAD_PLUGINS'].nil?
  if ARGV.include?('db:migrate')
    STDERR.puts "You are attempting to run migrations in your test environment and are not loading plugins, setting LOAD_PLUGINS to 1"
    ENV['LOAD_PLUGINS'] = '1'
  end
end

require_relative '../config/boot'
require 'rake'
Rake.application.run

Be sure to use the binstubs, they are faster as well.

fzngagan · October 14, 2020, 7:17am

Thanks for the tip. binstubs are super cool. I’ve read you say this somewhere but didn’t realize the utility of that.
Do you think monkey patching the task is taking things too far?

sam · October 14, 2020, 7:18am

Yeah I prefer just to keep it as is for now, bundle exec rake is slower and a lot longer to type. Using rake without bundler is risky.

fzngagan · October 14, 2020, 7:20am

Ah, I didn’t realize that. I’ll read up on this.