merefield
02.Сентябрь.2024 06:55:46
19
Обратите внимание: этот PR был создан и должен окончательно закрыть эту проблему, так как он уже был протестирован на экземпляре создателя бага через форк плагина опросов:
main ← merefield:ranked_choice_voter_expansion_fix
merged 01:28AM - 05 Nov 24 UTC
Currently, for Ranked Choice results and voter list expansion, the code is repla… cing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls.
See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18?u=merefield
I've made the tests more strict to cover this and confirmed test failure with existing code without this fix.
NB I'm aware code changes around this functionality have been a little numerous of late, so this time, in the interest of minimising review burden and curtailing the iteration, I made sure the changes in this PR were fully tested in Production on the very poll which identified the issue. We've successfully tested the solution in the Production instance of the bug raiser and they have signed off. (We removed the core plugin in app.yml and cloned a fork of Poll that includes these changes).
2 лайка