Remove overriding of cmd/ctrl-f

ux
1

How to recreate:

  1. Use major browsers (chromium derivatives / ffx / ie)
  2. browse the internet
  3. become accustomed to using standard keyboard commands like cmd-q, cmd-1/2/3, cmd-f
  4. continue browsing
  5. encounter a discourse website
  6. press cmd-f because you want to find something on the page
  7. get an entirely different experience that is generally worse*
  8. throw computer out the window. abandon life on the internet as it is. move to desert island and eat sushi for a hot minute

Examples of “worse”

  • frequently doesn’t actually find things on the page
  • requires a minimum number of characters
  • doesn’t allow repeat presses of cmd-f to cycle and search

Proposed Solution:
Remove the functionality in its entirety.

2 Likes
2

I’m not sure this is a bug, per se.

Perhaps rather a suggestion?

3

I dunno… if I were on a discourse website and wanted to click in the URL bar and it didn’t work, wouldn’t that be a “bug”

How is this any different?

4

You can type a second control-f to get to the browser search. It’s the best key to use for search. Do you have a better idea?

5

yes yes. better solution:
press cmd-f once. (as in, not twice) (also, to preempt any other ideas: not three or more times either)

this is paraphrased from the original post as:

“Remove the functionality in its entirety.“

6

The irony that this particular instance of discourse must have disabled this feature is not lost. Have the powers that be around here recognized its inferiority?

7

Maybe the topic you tried on was short

2 Likes
8

See, this is the bug:

" most of the post and topic stream is not in the browser DOM"

Maybe stop loading some much javascript, css and pretty images and focus on loading the text of the conversation.

Then native cmd-f would work just fine.

“twice if you think you’re smarter than Discourse. Find out if you are”

Literally every time I just scroll down the page real fast to load all the crap up. Then press cmd-f twice and it works better.

10

This is not true.

Feature exists here as well:

Go to: Introducing experimental admin sidebar navigation - #61 by martin hit ctrl-f

1 Like
13

When you do this, to improve scrolling & rendering performance, Discourse removes earlier posts from the DOM. So it is impossible to ‘load all’ of a large topic.

That’s why we have the custom ctrl+f implementation, and we only use it for long topics which are impossible to load in their entirety.

5 Likes
16

Seems to me like you’re just making excuses. Hijacking native functionality should be a hard no. 99.9% of sites on the internet respect this. Why is discourse special?

17

There’s a huge amount of history on this subject in lots of topics over the years. If you have a search you’ll be able to see the past conversations. :+1:

4 Likes
18

GitHub, Google docs/slides/etc. hijack it as well, and I suspect it’s good for performance here, and is why it’s done.

2 Likes
19

GitHub, Google docs/slides/etc. hijack it as well, and I suspect it’s good for performance here, and is why it’s done.

Excellent opportunity for discourse to be a leader in not-clobbering-native-functionality!

You could point fingers at the big guys and show em who’s boss.

20

What keystroke would you recommend for people who expect control-F to find the post they are looking for in the topic when that post isn’t available in the browser. It would seem like what you would expect is for control-F to find the post you want in that topic, but that’s not what you want. What’s the “find the post in this topic even if my browser can’t find it” key? Isn’t having control-f not find a post in the current topic a violation of expectations?

3 Likes