tpetrov
(Toni Petrov)
13 Novembre 2020, 4:08pm
1
I wanted to write about that but saw it was raised already
I agree that itās not necessary by default because itās a short form, but itās bad that we do two different things when custom fields are present. We do already have a class in there when custom fields are present, so I think itās an easy change to show asterisks for all required fields in that case.
In short when you have custom fields that are required they show with asterisk, but the main fields e.g. email, username⦠donāt have it although they are also required, which is a bit confusing.
5 Mi Piace
I have a pull request for this ready for review here:
master ā awesomerobot:required-fields
merged 11:26PM - 07 Dec 20 UTC
When custom user fields are required at signup we show an asterisk to label them⦠as required... but we don't do this for our default inputs. For the sake of consistency, this change adds an asterisk to our default sign-up fields only if custom user fields are present.
This is a compromise between being simple by default, and consistent with added customization.


Relevant discussion here: https://meta.discourse.org/t/required-should-be-next-to-all-required-fields-in-sign-up-form/126235 and more recently here: https://meta.discourse.org/t/required-fields-not-shown-as-required-during-sign-up/170052
This may not be merged for a week or two because weāre preparing for our next major release and changes that arenāt immediately necessary are on hold.
Iāll update when this topic when itās been merged.
5 Mi Piace
The above change has been merged in, so youāll see the fields marked as required the next time your site is updated.
4 Mi Piace
awesomerobot
(Kris)
Ha separato questo argomento il
12 Novembre 2024, 2:36pm
4
Un post ĆØ stato diviso in un nuovo argomento: Modifiche recenti al modulo di iscrizione