مراجعة - أضف غرف صوتية على غرار ديسكورد إلى مجتمعك 🎙

Falco · 30 يوليو 2026، 7:09م

شكراً لك على التقرير المفصل، لقد قمت بدمج طلب السحب (PR) الخاص بذلك:

github.com/discourse/resenha

FIX: Presence race conditions, admin room_type handling, and LiveKit log noise (#72)

main ← fix-presence-and-room-type-bugs

merged 06:05PM - 30 Jul 26 UTC

xfalcox

+282 -3

This addresses five user-reported bugs around presence tracking, room types, and… LiveKit reconciliation. One commit per fix. ## 1. Racing heartbeats resurrected departed users (ghost presence) A heartbeat already in flight when a `leave` or `kick` was processed landed second and unconditionally re-added the departed user's presence. Because the TTL reap never broadcasts, the ghost stayed visible to other clients until the next republish sweep — up to a minute. Leave and kick now write a short-lived Redis tombstone (15s — one heartbeat interval plus latency) that `heartbeat` checks before re-adding presence. `join` and the reconnect ladder's `livekit_token` endpoint clear it, since both are explicit statements that the user is (re-)entering the call. ## 2. `room_type` could not be set through the admin UI, and unknown values silently became "open" The admin controller never permitted `room_type` and the admin serializer never returned it, so the admin form always displayed (and submitted) "open" — stage assignments made there were silently dropped. Both halves land together deliberately: permitting the param while the form still prefills "open" from the missing serializer field would flip existing stage rooms back to open on any admin edit. The user-facing controller also mapped unknown `room_type` values to open as a silent fallback. Both controllers now share a strict model-level lookup that rejects unknown names with a 400 — the column is an integer, so an unmapped name would otherwise cast to `0` (open) and corrupt the room. ## 3. A superseded LiveKit session's late departure webhook dropped a fresh session Departure webhooks were matched by user identity alone. On a quick disconnect/rejoin, the old session's `participant_left` routinely arrives after the new session is connected, and the `gone_at` heuristic can't tell them apart (the rejoin's presence timestamp predates the old session's disconnect), so the new session's presence was expired and the user vanished from the roster until their next heartbeat. `participant_joined` events now record the session SID per user, and a departure whose SID differs from the recorded one is skipped as superseded. Departures without SID context on either side still expire presence, keeping the webhook's reconcile-only backstop role intact. Webhook delivery is unordered, so this narrows the race window rather than sealing it — the next heartbeat still recovers the residual case. ## 4. The last leave's `DeleteRoom` race logged as a failure The SFU tears an emptied room down on its own, so the `DeleteRoom` issued by the last participant's leave routinely finds the room already gone and 404s. That's the desired end state, not a fault, yet it landed in Logster on every last-leave (and again from the emptied-room sweep). `DeleteRoom` now treats 404 as success at debug level; every other call and status keeps warning.

الموضوع		الردود	مرات العرض
Introducing Discourse Chat (BETA) Announcements chat , new-feature	142	27696	3 أغسطس 2022
Discourse Chat Plugin official , chat , included-in-core	43	33958	29 يوليو 2026
Discord and Discourse - Better Together \| Blog Blog	12	4996	28 ديسمبر 2021
3.3.0.beta2: New admin sidebar, Redesigned bookmark menu, Chat from user profile, and more Announcements release-notes	1	2047	15 مايو 2024
Speccing out a full page chat plugin Development	29	8144	21 أغسطس 2022

مراجعة - أضف غرف صوتية على غرار ديسكورد إلى مجتمعك 🎙

الموضوعات ذات الصلة