Return something else than a 404 for deleted subjects

riking · 18 Septiembre, 2015 07:25

That change is in:

https://github.com/discourse/discourse/pull/3785/

This snippet is what error codes we’re currently giving out:

spec/controllers/topics_controller_spec.rb

c9e4745fe


      
          context 'anonymous' do
            expected = {
              :normal_topic => 200,
              :secure_topic => 403,
              :private_topic => 302,
              :deleted_topic => 410,
              :deleted_secure_topic => 403,
              :deleted_private_topic => 302,
              :nonexist => 404
            }
            topics_controller_show_gen_perm_tests(expected, self)
          end
          
          context 'anonymous with login required' do
            before do
              SiteSetting.login_required = true
            end
            expected = {
              :normal_topic => 302,
              :secure_topic => 302,

This file has been truncated. show original

The “private (message) topic → 302” seems a bit weird, especially since we give a 403 (same as secure category) for signed-in users.

Tema		Respuestas	Vistas
Turning 404 pages into 410s for faster de-indexing Product Support	5	145	9 Junio 2025
Canonical tag on topic URL Bug	22	2791	7 Febrero 2017
The response for an absent tag page should contain the «404» HTTP status code, not «200» Bug	9	1814	13 Abril 2016
Googlebot 404 errors due to page numbers Product Support	14	1208	21 Mayo 2026
Being on a topic page when it is deleted shows an empty page UX	1	569	8 Mayo 2020

Return something else than a 404 for deleted subjects

Temas relacionados