Problème
J’ai rencontré une incohérence apparente lors de la réversion d’une révision de message contenant du BBCode d’événement (Event).
Après avoir rétabli une révision antérieure, le onebox d’événement affiché montre bien la date de l’événement précédent, mais l’ouverture de l’éditeur de message indique que le code BBCode [event] sous-jacent contient toujours la date de la révision plus récente.
Cette divergence persistait après rechargement du sujet.
Je me demande si cela est lié aux récents changements dans la manière dont les oneboxes d’événements récurrents sont rendus.
Étapes menant au problème
Commencez avec un message contenant du BBCode d’événement, incluant les dates de début et de fin.
Modifiez l’événement pour changer sa date ou son heure, puis enregistrez.
Ouvrez l’historique des révisions du message.
Rétablissez la révision antérieure.
Observez que le onebox d’événement affiché change pour la date antérieure.
Ouvrez l’éditeur de message et inspectez les attributs [event start="..." end="..."].
Observez que le code BBCode contient toujours la date plus récente, malgré la réversion apparente.
Comportement attendu
Si la réversion d’une révision est censée restaurer les dates d’événement originales, je m’attendrais à ce que l’événement affiché et le code BBCode sous-jacent reflètent tous deux les valeurs rétablies.
Alternativement, si le onebox d’événement affiche intentionnellement une occurrence calculée dynamiquement qui diffère du code BBCode stocké, il serait utile de clarifier la façon dont cela doit interagir avec l’historique des révisions.
Comportement réel
Le onebox d’événement reflétait la date antérieure, tandis que l’éditeur de message continuait d’afficher la date plus récente dans son code BBCode.
J’ai corrigé manuellement le code BBCode pour rétablir la cohérence.
Changements en amont pertinents
J’ai remarqué que la récente PR de @awesomerobot a introduit des informations de récurrence et mis à jour la gestion des occurrences pour les oneboxes d’événements :
main ← event-onebox-recurrence
This adds recurrence information to event oneboxes, including the end date (when… set)
<img width="700" alt="image" src="https://github.com/user-attachments/assets/56f9416d-4695-4ae3-a51d-c228c15c187b" />
To accomplish this it:
- Adds a schema.org `eventSchedule` to the event JSON-LD (frequency, day, week of the month, end date, timezone), and has the onebox read it.
- Stores the schedule in the onebox as a recurrence rule, and works out the current occurrence on the server with the existing `rrule` setup. Posts get it through a new `event_onebox_occurrences` serializer field, and emails get it through `reduce_cooked`, so neither shows a past date.
- Updates the date badge's `<time datetime>` together with the visible date.
D’après ma compréhension, ce changement permet aux oneboxes d’événements récurrents d’afficher l’occurrence actuelle en utilisant les informations de récurrence, plutôt que d’afficher nécessairement la date originale stockée dans le balisage du onebox.
J’ai également rencontré un conflit de fusion en amont impliquant la gestion de la récurrence des événements lors de la mise à jour de ma propre PR, toujours ouverte :
main ← Ethsim12:feature-recurring-event-topic-mode
## Summary
Adds an opt-in mode for recurring Events where each completed occu… rrence is preserved in its own Topic and the next occurrence is created in a successor Topic.
The new `discourse_post_event_recurring_topic_mode` enum site setting has two values:
- `reuse_topic` — existing behavior and the default
- `create_next_topic` — archive the completed occurrence Topic and create a successor Topic for the next occurrence
The existing reuse-topic behavior is retained. Successor-topic creation applies only when the new mode is explicitly enabled.
## Details
When `create_next_topic` is enabled, the scheduled event-date monitor:
- preserves the completed Topic by converting its recurring Event into a one-off occurrence, retaining the completed dates and attendance
- renames the archived Topic using a distinctive date-bearing title, such as `Meeting (archived event on 2026-09-03)`, respecting title-length and duplicate-title validation
- creates a successor Topic from the original post content, advancing the Event start/end dates while preserving unrelated content and Event attributes
- preserves the category, tags, original author and recurring Event metadata
- carries forward recurring `going` invitees while leaving one-off attendance associated with the completed occurrence
- performs archival and successor creation transactionally, so a failed rollover leaves the occurrence pending for retry without partially archiving the Event
- emits the `discourse_post_event_event_ended` workflow trigger with the completed occurrence's recurring-series metadata
If the recurrence has no next occurrence, the completed Topic is retained as a one-off Event and no successor Topic is created.
### Archived Topic titles
The archived title initially uses the format:
`{original title} (archived event on {YYYY-MM-DD})`
The title is truncated where necessary to respect `SiteSetting.max_topic_title_length`, while preserving as much of the distinguishing suffix as possible.
Rather than querying for duplicate titles before every archival revision, the implementation relies on Discourse's existing Topic validation. If `PostRevisor#revise!` fails solely because the archived title is already in use, it retries with an additional Topic ID or numbered suffix.
The generic suffix-generation logic is implemented in `Topic#title_with_disambiguating_suffix`. Retries are bounded to five attempts, and unrelated revision failures are not retried.
The retry is attached to `PostRevisor`, because archival renames the **existing Topic**. `PostCreator.create!` subsequently creates the successor using the original title.
Duplicate-title validation retains Discourse's normal category and visibility rules, including the treatment of Topics hidden from the original author.
### Recurrence and editing
The implementation preserves the original recurrence anchor separately from the displayed occurrence start date. This allows successor Topics to retain recurrence patterns such as the last weekday of a month without drifting to a different ordinal weekday.
The Event serializer and frontend recurrence handling use this anchor when reconstructing the recurring schedule. Explicit changes to the recurrence pattern or relevant dates can update the anchor.
The successor service also:
- distinguishes rendered Event markup from examples inside fenced code blocks
- recognises unquoted BBCode attribute values containing characters such as apostrophes
- rewrites actual Event attributes positionally, without altering attribute-like words inside quoted names or locations
- handles differently capitalised aliases of Event attributes
- preserves seconds and fractional seconds in timed Event attributes where present, avoiding unintended changes to Event dates during archival
- preserves completed Event dates and RSVP information when archiving an occurrence, including Events without an explicit end time
- handles Events removed from a successor Topic and subsequently recreated without inheriting stale recurrence-anchor data
Generic BBCode parsing and attribute rewriting have been extracted from the successor service into reusable core functionality.
The implementation uses the `BbcodeRewriter` scan/mark/rewrite path. The separate, unused token-based `PrettyText.update_bbcode_attributes` API was removed from this PR in [6d13371](https://github.com/discourse/discourse/pull/43187/commits/6d13371aae5), avoiding two parallel rewriting mechanisms.
### Access control and moderation
Successor-topic creation is restricted to eligible standard Topics. Recurring Events in private messages continue using their existing Topic, preserving the original private-message access restrictions rather than creating potentially public successors.
Automated successor creation uses the system user as the acting user for creation and the required Event validation. The original author remains the author of the successor Topic and the editor of the archived post, preserving normal editing attribution and rendering permissions.
This allows an established recurring series to continue after ordinary Event-creation group or category permission changes.
However, successor creation is deferred when:
- the original author is suspended, silenced, inactive, staged or otherwise prevented from posting
- the original post is hidden or deleted
- the source Topic is non-visible or deleted
- a recorded raw-content edit by another human user makes republication under the original author's identity unsafe
The last restriction prevents an editor of another user's wiki post from introducing a recurring Event that later publishes new non-wiki Topics under the original author's identity.
Trusted system-user revisions and metadata-only edits by another human user, such as moderator title changes, do not automatically prevent rollover.
These checks apply both to the scheduled monitor and to direct calls to the successor-creation service.
When rollover is deferred, the occurrence remains pending rather than being archived or publicly republished. The monitor emits a diagnostic warning at most once every 24 hours per affected Event occurrence, avoiding repeated warnings on every scheduled run.
This approach is deliberately conservative: a legitimate raw-content edit by another human user can also defer rollover because the implementation does not separately persist the principal who originally authorised the Event content.
### Event hosts
A recurring Event may retain hosts who subsequently become ineligible to host a newly created Event.
During rollover:
- the archived occurrence retains its existing eligible or ineligible host associations for historical accuracy
- archived hostnames are reconstructed from persisted host associations, avoiding failures caused by renamed or stale usernames
- the successor inherits only hosts who currently satisfy the relevant account and category eligibility requirements
- rollover can continue when no eligible hosts remain
This prevents an inherited suspended, inactive or otherwise ineligible host from repeatedly blocking successor creation.
### Service architecture and failure isolation
Successor creation uses Discourse's `Service::Base` framework, including parameter validation, model resolution, a `rollover_allowed` policy and transactional service steps.
The scheduled monitor handles exceptions separately for each Event date, logging the affected occurrence without preventing the remaining pending Events from being processed.
Failed successor creation rolls back the archival transaction. A subsequent monitor run can retry the occurrence without leaving a partially archived Event or duplicate successor.
## UI smoke test
The original UI and scheduled-job smoke tests were performed with `discourse_post_event_recurring_topic_mode` set to `create_next_topic`.
**Site setting**
<img width="678" height="142" alt="01-admin-setting-create-next-topic" src="https://github.com/user-attachments/assets/78dc6698-6886-4c10-81d4-22d991f0f452" />
**Before rollover — recurring occurrence on September 3**
<img width="1512" height="958" alt="02-before-rollover-sep-3-every-thursday" src="https://github.com/user-attachments/assets/3150b843-1264-4990-8dd8-2e931e28b9dc" />
**Completed occurrence preserved in the archived Topic**
<img width="2048" height="1076" alt="03-archived-topic-2026-09-03" src="https://github.com/user-attachments/assets/d6d28341-f684-4ba8-9b54-2fec0c537bb7" />
**Successor Topic created for the next weekly occurrence**
<img width="2048" height="1073" alt="04-successor-topic-sep-10-every-thursday" src="https://github.com/user-attachments/assets/0ff611b4-f316-4130-bb75-7948d36e61e9" />
These initial smoke tests confirmed that the completed Topic was preserved with a dated title and that a successor Topic was created for the following weekly occurrence, including through the normal supervised Sidekiq scheduler.
**Note:** These screenshots were captured before the subsequent review-driven changes, including the revised archived-title format. They demonstrate the original end-to-end functionality rather than the exact appearance of the latest implementation.
## Tests
### Latest combined local regression run — 27 October 2026
> **453 examples, 0 failures**
Executed against commit `909b0c7`, including the BBCode API cleanup and archived-title refactor.
The run covered:
- `spec/models/topic_spec.rb`
- `plugins/discourse-events/spec/services/discourse_events/events/event/create_successor_topic_spec.rb`
- `plugins/discourse-events/spec/jobs/scheduled/monitor_event_dates_spec.rb`
- `plugins/discourse-events/spec/lib/bbcode_rewriter_spec.rb`
- `spec/lib/pretty_text_bbcode_rewriter_spec.rb`
Coverage includes:
- Topic model validation and duplicate-title behaviour
- normal recurring Event rollover and final occurrence handling
- archived-title formatting, truncation and collision recovery
- bounded title retries and rejection of unrelated validation failures
- duplicate-title visibility rules for Topics hidden from the original author
- BBCode parsing, rewriting and preservation of unrelated attributes
- Event attribute aliases and preservation of timestamp precision
- successor-service eligibility policies and transactional rollback
- existing scheduled-monitor regression scenarios
An additional focused regression test for archived-title collisions involving a Topic hidden from the author also passed independently.
### Earlier Event and workflow regression run
> **168 examples, 0 failures**
The earlier run covered:
- `spec/jobs/scheduled/monitor_event_dates_spec.rb`
- `spec/models/discourse_events/events/event_spec.rb`
- `spec/integration/workflows_event_triggers_spec.rb`
Coverage included:
- existing reuse-topic behavior, normal successor rollover and final recurrence
- all-day Events, timezones and monthly recurrence anchors
- private-message confidentiality and account-level moderation safeguards
- restricted original authors and changes to category/Event-creation permissions
- cross-user wiki edits, system-user revisions and moderator metadata-only edits
- transactional rollback, failure isolation and retry behaviour
- recurring RSVP inheritance and preservation of completed attendance
- workflow event-ended payloads
- rate-limited warnings when rollover is deferred
This was a separate, earlier test run, not part of the latest 453-example invocation.
### Formatting and linting
The latest modified Ruby files passed SyntaxTree and RuboCop:
> **4 files inspected, no offences detected**
The pre-commit hooks also passed for both review-driven refactor commits. The resulting working tree was clean.
The original UI smoke tests predate the later review-driven changes; the local regression runs above provide coverage of the subsequent implementation.
J’ai résolu ce conflit en préservant la gestion de la récurrence en amont tout en conservant le comportement d’ancrage de récurrence requis par l’implémentation du sujet successeur.
Je mentionne ceci pour fournir un contexte de développement, et non pour suggérer que la PR #43187 soit responsable du comportement observé sur mon site.
Environnement
Questions
Pourrait-on vérifier l’interaction entre la réversion des révisions de message, le code BBCode d’événement stocké et la nouvelle gestion de la récurrence des oneboxes d’événements ?
En particulier :
Est-il attendu que la réversion d’une révision puisse modifier le onebox d’événement sans restaurer les attributs BBCode correspondants ?
La nouvelle logique de calcul des occurrences pourrait-elle expliquer que la date affichée change indépendamment de la source stockée du message ?
Si le code BBCode sous-jacent aurait dû être réverté, s’agit-il d’une lacune dans le processus de restauration des révisions ?
J’apprécierais des clarifications sur le fait de savoir si ce comportement est attendu ou s’il s’agit d’une régression.