ryantm
(Ryan Mulligan)
March 2, 2016, 1:35am
1
Hello.
Using GitHub - nlalonde/ruby-bbcode-to-md: Convert BBCode to Markdown. like
"[youtube]https://www.youtube.com/watch?v=COvnHv42T-A[/youtube]".bbcode_to_md
it returns
"http://www.youtube.com/watch?v=COvnHv42T-A"
stripping away the https.
Ryan
1 Like
Hmm yeah that looks like a bug we should fix. Does it affect Discourse too, presumably yes?
1 Like
ryantm
(Ryan Mulligan)
March 2, 2016, 5:31pm
3
Yes, because Importing from phpBB3 recommends using it.
1 Like
gerhard
(Gerhard Schlager)
March 2, 2016, 10:53pm
4
I think you are mistaken. That Howto doesn’t recommend using bbcode_to_md.
Well, it doesn’t discourage its usage either, but at least it’s off by default.
And does it affect Discourse itself? No, only the import scripts that are using that gem.
1 Like
ryantm
(Ryan Mulligan)
March 2, 2016, 11:20pm
5
Sorry, you’re right. I was taking the suggestion of installing the gem as a dependency too far.
ryantm
(Ryan Mulligan)
March 4, 2016, 11:07pm
6
5 Likes
neil
(Neil Lalonde)
March 7, 2016, 3:55pm
7
Thanks @ryantm ! I merged the changes. Also thanks for improving the tests.
3 Likes