Ruby-bbcode-to-markdown removes https

[ryantm (Ryan Mulligan)]

Hello.

Using https://github.com/nlalonde/ruby-bbcode-to-md like

"[youtube]https://www.youtube.com/watch?v=COvnHv42T-A[/youtube]".bbcode_to_md

it returns

"http://www.youtube.com/watch?v=COvnHv42T-A"

stripping away the https.

Ryan

[codinghorror (Jeff Atwood)]

Hmm yeah that looks like a bug we should fix. Does it affect Discourse too, presumably yes?

[ryantm (Ryan Mulligan)]

Yes, because Importing from phpBB3 recommends using it.

[gerhard (Gerhard Schlager)]

I think you are mistaken. That Howto doesn’t recommend using bbcode_to_md.
Well, it doesn’t discourage its usage either, but at least it’s off by default.

And does it affect Discourse itself? No, only the import scripts that are using that gem.

[ryantm (Ryan Mulligan)]

Sorry, you’re right. I was taking the suggestion of installing the gem as a dependency too far.

[ryantm (Ryan Mulligan)]

I made a PR to @neil 's repo to fix this by making it always be https. https://github.com/nlalonde/ruby-bbcode-to-md/pull/2

[neil (Neil Lalonde)]

Thanks @ryantm! I merged the changes. Also thanks for improving the tests.