Ruby-bbcode-to-markdown removes https

(Ryan Mulligan) #1

Hello.

Using GitHub - nlalonde/ruby-bbcode-to-md: Convert BBCode to Markdown. like

"[youtube]https://www.youtube.com/watch?v=COvnHv42T-A[/youtube]".bbcode_to_md

it returns

"http://www.youtube.com/watch?v=COvnHv42T-A"

stripping away the https.

Ryan

(Jeff Atwood) #2

Hmm yeah that looks like a bug we should fix. Does it affect Discourse too, presumably yes?

(Ryan Mulligan) #3

Yes, because Importing from phpBB3 recommends using it.

(Gerhard Schlager) #4

I think you are mistaken. That Howto doesn’t recommend using bbcode_to_md.
Well, it doesn’t discourage its usage either, but at least it’s off by default. :wink:

And does it affect Discourse itself? No, only the import scripts that are using that gem.

(Ryan Mulligan) #5

Sorry, you’re right. I was taking the suggestion of installing the gem as a dependency too far.

(Ryan Mulligan) #6

I made a PR to @neil 's repo to fix this by making it always be https. default youtube tag urls to always be https by ryantm · Pull Request #2 · nlalonde/ruby-bbcode-to-md · GitHub

(Neil Lalonde) #7

Thanks @ryantm! I merged the changes. Also thanks for improving the tests.

(Jeff Atwood) #8