ryantm
(Ryan Mulligan)
2 مارس 2016، 1:35ص
1
Hello.
Using GitHub - nlalonde/ruby-bbcode-to-md: Convert BBCode to Markdown. like
"[youtube]https://www.youtube.com/watch?v=COvnHv42T-A[/youtube]".bbcode_to_md
it returns
"http://www.youtube.com/watch?v=COvnHv42T-A"
stripping away the https.
Ryan
إعجاب واحد (1)
Hmm yeah that looks like a bug we should fix. Does it affect Discourse too, presumably yes?
إعجاب واحد (1)
ryantm
(Ryan Mulligan)
2 مارس 2016، 5:31م
3
Yes, because Importing from phpBB3 recommends using it.
إعجاب واحد (1)
gerhard
(Gerhard Schlager)
2 مارس 2016، 10:53م
4
I think you are mistaken. That Howto doesn’t recommend using bbcode_to_md.
Well, it doesn’t discourage its usage either, but at least it’s off by default.
And does it affect Discourse itself? No, only the import scripts that are using that gem.
إعجاب واحد (1)
ryantm
(Ryan Mulligan)
2 مارس 2016، 11:20م
5
Sorry, you’re right. I was taking the suggestion of installing the gem as a dependency too far.
ryantm
(Ryan Mulligan)
4 مارس 2016، 11:07م
6
5 إعجابات
neil
(Neil Lalonde)
7 مارس 2016، 3:55م
7
Thanks @ryantm ! I merged the changes. Also thanks for improving the tests.
3 إعجابات