ryantm
(Ryan Mulligan)
Mars 2, 2016, 1:35
1
Hello.
Using GitHub - nlalonde/ruby-bbcode-to-md: Convert BBCode to Markdown. like
"[youtube]https://www.youtube.com/watch?v=COvnHv42T-A[/youtube]".bbcode_to_md
it returns
"http://www.youtube.com/watch?v=COvnHv42T-A"
stripping away the https.
Ryan
1 « J'aime »
Hmm yeah that looks like a bug we should fix. Does it affect Discourse too, presumably yes?
1 « J'aime »
ryantm
(Ryan Mulligan)
Mars 2, 2016, 5:31
3
Yes, because Importing from phpBB3 recommends using it.
1 « J'aime »
gerhard
(Gerhard Schlager)
Mars 2, 2016, 10:53
4
I think you are mistaken. That Howto doesn’t recommend using bbcode_to_md.
Well, it doesn’t discourage its usage either, but at least it’s off by default.
And does it affect Discourse itself? No, only the import scripts that are using that gem.
1 « J'aime »
ryantm
(Ryan Mulligan)
Mars 2, 2016, 11:20
5
Sorry, you’re right. I was taking the suggestion of installing the gem as a dependency too far.
ryantm
(Ryan Mulligan)
Mars 4, 2016, 11:07
6
5 « J'aime »
neil
(Neil Lalonde)
Mars 7, 2016, 3:55
7
Thanks @ryantm ! I merged the changes. Also thanks for improving the tests.
3 « J'aime »