Hi everyone, I’m getting started on developing things for Discourse, and I’m working on a theme component.
Link: GitHub - NateDhaliwal/discourse-persistent-banner: A theme component for Discourse that cannot be closed by the user.
When putting it on Theme Creator, the settings don’t appear, even though I have a settings.yml
. Any ideas?
إعجاب واحد (1)
Moin
20 سبتمبر 2024، 8:28ص
2
Do you see any error messages at theme creator?
I think you have to use the same quotation marks at the beginning and end.
This could also be a problem. I would try default: ""
Maybe you want to add “block” to the choices. Otherwise you have to use the revert button to choose that again.
إعجابَين (2)
Whoops, just realised I was clicking on ‘Create new’ instead of importing it…
But now, when I try using the URL, it says that about.json
is invalid or doesn’t exist, asking me if it is a theme.
About.json:
{
"name": "Persistent banner",
"about_url": "",
"license_url": "https://github.com/NateDhaliwal/discourse-persistent-banner/blob/main/LICENSE"
"component": true,
"version": 1.0.0,
"authors": "NateDhaliwal"
}
Is there something wrong?
Missing comma after license URL.
4 إعجابات
@merefield Would version be in ""
?
إعجاب واحد (1)
Probably that too. Just look at examples.
إعجاب واحد (1)
Thanks! One last one, I can’t seem to get the variable to display.
Was it because I didn’t initialise it properly? I tried following the guide…
Would I have to use
import Component from "@glimmer/component";
export default class PracticeComponent extends Component {
get bannerLinks() {
return JSON.parse(settings.banner_links);
}
}
then?
إعجاب واحد (1)
Look at the billions of examples
إعجاب واحد (1)
You only need to use a gjs file if you need to process stuff with javascript, otherwise an hbs template file might suffice. Experiment.
إعجاب واحد (1)
I’m not sure if I’m going in the right direction.
I made javascripts/persistent-banner.hbs
with this:
But nothing shows up. Tried putting it in different places, still won’t work.
Tried looking at example, but many don’t seem to help.
Any advice?
إعجاب واحد (1)
Moin
21 سبتمبر 2024، 11:51ص
13
In which plugin outlet do you want to put your banner?
Take a look at Using Plugin Outlet Connectors from a Theme or Plugin
You could use Add a featured topic list to your Discourse homepage as an example
You can use the Plugin outlet locations theme component to find the names and locations of the plugin outlets. “above-main-container” for example is the top one above the topic list, but not above the sidebar.
Looking at the code of a Theme component which adds something similar is also a great way to learn.
إعجابَين (2)
You do not need and should not put script tags in hbs files. They should be limited to the content of the template.
Don’t stab in the dark, read the guides:
There's a new component API in Octane! For this section, we'll be focusing on the differences between the new style, known as Glimmer components, and classic components, and how to upgrade. "Classic" components refer to older-style components that do...
3 إعجابات
So… I managed to get it working without using a hbs file, but instead using the <script>
tag with handlebars, and it now works.
I use it like this for now, but I’ll continue to try using a hbs file instead.
إعجاب واحد (1)
Lilly
(Lillian Louis)
22 سبتمبر 2024، 3:24ص
16
created a quick pull request for you so you can see the way to split up the files properly. feel free to merge or just have a look at the branch .
NateDhaliwal:main
← Lillinator:split-into-handlebars-files
opened 03:22AM - 22 Sep 24 UTC
split into the handlebars files for you :)
also removed the header.html file
6 إعجابات
Thanks so much! It works now!
إعجاب واحد (1)
Lilly
(Lillian Louis)
22 سبتمبر 2024، 3:15م
18
No worries Nate. Keep up the experimenting, reading and looking at other examples. In no time you’ll be much better than I am at this dev stuff
إعجابَين (2)
Thanks for the encouragement!
إعجاب واحد (1)
system
(system)
تم إغلاقه في
22 أكتوبر 2024، 10:58م
20
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.